-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vocabulary.md #68
base: main
Are you sure you want to change the base?
Conversation
doc change for multiple vocab description
✅ Deploy Preview for concerto-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -4,11 +4,14 @@ title: Vocabulary | |||
sidebar_position: 5 | |||
--- | |||
|
|||
The Vocabulary module for Concerto optionally allows human-readable labels (Terms) to be associated with model elements. Terms are stored within a locale specific vocabulary YAML file associated with a Concerto namespace. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this extra line?
- Truck: A vehicle capable of carrying cargo | ||
properties: | ||
- weight: The weight of the truck in KG | ||
- Color: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This vocabulary yam file is incorrect. Please refer to the vocabulary file here.
https://github.com/accordproject/concerto/pull/664/files#diff-ebc9ab70877a4dfb90adb68e9c70c0532b0c79567a6b96ff4761a2df1071f6f3
``` | ||
const term = vocabularyManager.getTerm('org.acme', 'en-gb', 'Color'); | ||
// term.should.equal('A colour'); | ||
const shortTerm = vocabularyManager.getTerm('org.acme', 'en-gb', 'Color', { termType: 'short' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const shortTerm = vocabularyManager.getTerm('org.acme', 'en-gb', 'Color', { termType: 'short' }); | |
const shortTerm = vocabularyManager.getTerm('org.acme', 'en-gb', 'Color', 'short'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API signature is different from the one mentioned here in this change. You may want to update at other places as well.
@darksapien23151 if you've used any AI tools for this task, can you please add an AI-Assistant tag to the PR. We are completely fine with using AI tools to help you with the dev work. But as we reviewers we have to be extra vigilant during our reviews to avoid slip ups. |
Documentation for support multiple vocabulary terms for a element.
Closes #
Changes
Related Issues