Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templates): render sample template name #66

Merged

Conversation

Vinyl-Davyl
Copy link
Collaborator

@Vinyl-Davyl Vinyl-Davyl commented Jun 5, 2024

Closes PR #33

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Previews

Screenshot 2024-06-07 122007 Screenshot 2024-06-07 121706

@Vinyl-Davyl Vinyl-Davyl requested a review from a team as a code owner June 5, 2024 15:40
@Vinyl-Davyl Vinyl-Davyl changed the base branch from main to gsoc'24-m1 June 5, 2024 15:51
@Vinyl-Davyl Vinyl-Davyl force-pushed the template-name-rendering branch from c7b5c31 to 2fca9e3 Compare June 6, 2024 02:14
@sanketshevkar
Copy link
Member

Can you also please add screen recording videos of the changes? It'll be easier for us to visualize the changes as we don't have testing in place.

@mttrbrts
Copy link
Member

mttrbrts commented Jun 6, 2024

Can you also please add screen recording videos of the changes? It'll be easier for us to visualize the changes as we don't have testing in place.

Perhaps we could add PR deploys to netlify, like we have for other apps? Let me know if you need permissions

@Vinyl-Davyl
Copy link
Collaborator Author

Vinyl-Davyl commented Jun 6, 2024

Can you also please add screen recording videos of the changes? It'll be easier for us to visualize the changes as we don't have testing in place.

okay, sure. would add some shots going on! it's a simplified PR fix from the other one closed though.

@Vinyl-Davyl
Copy link
Collaborator Author

Can you also please add screen recording videos of the changes? It'll be easier for us to visualize the changes as we don't have testing in place.

Perhaps we could add PR deploys to netlify, like we have for other apps? Let me know if you need permissions

👍🏼 we would look into this.

@sanketshevkar
Copy link
Member

okay, sure. would add some shots going on! it's a simplified PR fix from the other one closed though.

Let me look at the netlify deployment, please rebase and add a unit test for this scenario. Considering this would be your first time writing unit tests, please give yourself sometime and get familiarized with react-testing-library and vitest.

@mttrbrts mttrbrts merged commit 60b9ef9 into accordproject:gsoc'24-m1 Jun 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants