[initdb] add user and lang options #101

MAG-Florian-Chevalier · 2021-09-10T15:57:58Z

MAG-Florian-Chevalier · 2021-09-10T16:01:09Z

Here is our first proposal to add the option to set username, password, language and all those options with the initdb command. At the moment, country and language seem to be working fine but login, password and phone aren't.
If you have any advice on this it will be welcomed.

Regards

codecov-commenter · 2021-09-11T11:36:17Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (fd022cc) to head (5410eb0).
Report is 91 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   93.19%   92.69%   -0.51%     
==========================================
  Files          14       14              
  Lines         896      903       +7     
  Branches      149      157       +8     
==========================================
+ Hits          835      837       +2     
- Misses         43       45       +2     
- Partials       18       21       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

flotho · 2021-09-24T14:16:46Z

Hi @sbidoul ,
We're trying to understand why you use the registry to create the database .
We found this method exp_create_database https://github.com/OCA/OCB/blob/14.0/odoo/service/db.py#L125 that doing everything needed.
Could you explain us what's hiding behind the Registry usage. We're suspecting that it is needed for managing the cache db or something like this.
Any advice here would be appreciated.
Regards

sbidoul · 2021-09-24T14:50:20Z

exp_create_db calls _initialize_db which does Registry.new too, so it's quite similar in behaviour ?

Otherwise, I don't remember why _initialize_db was not used, sorry.

flotho · 2021-09-24T17:41:34Z

Hi @sbidoul ,

So if we continue in the direction of using this method there https://github.com/acsone/click-odoo-contrib/pull/101/files#diff-7ef2b7bba0483174747437d28282a83c065ceb8bed4021ed382ebdacc021ce91R72 could it be a valid contribution for you or do you have some requirements to share with us?

Regards

* add new params for initdb. add login password lang and country * fix no cache with specific modules * fix no cache with specific modules

MAG-Florian-Chevalier · 2021-10-15T12:30:50Z

ping @sbidoul PR is ready for review

sbidoul

A couple of comment.

This would need tests.

sbidoul · 2021-10-15T12:39:54Z

click_odoo_contrib/initdb.py

        if new_database:
-            odoo_createdb(new_database, demo, module_names, False)
+                odoo_createdb_without_cache(new_database, demo,module_names, lang, password, login, country, phone)


Actually the cache options, controls the caching of database templates. This apparently merely disables _save_installed_checksums, which I think is good to preserve in this branch too.

Actually, there should be no reason to not cache in this case, and this should be doable easily by including lang, password, etc in the addons_hash() function, like the demo flag is already handled.

Note that phone was not supported in older Odoo versions ?

sbidoul · 2021-10-15T12:43:18Z

README.rst

+    --login TEXT              Set admin login.
+                              Imcompatibility with --cache. [default: admin]
+    --country TEXT            Set default country.
+                              Imcompatibility with --cache. [default: GB]


Is GB the default for Odoo ?

flotho · 2021-10-18T14:47:10Z

Hi @sbidoul thanks for your feedback, @gaelTorrecillas and @MAG-Florian-Chevalier will have a look to your comments

sbidoul · 2021-10-18T14:50:53Z

And thanks for contributing :)

flotho · 2021-10-19T10:18:09Z

And thanks for contributing :)

we're fan of your modules, so we're contributing

MAG-Florian-Chevalier · 2021-10-22T14:15:19Z

Hi @sbidoul, we've changed the code according to your comments.
We have tested this in v12 and v14 and everything seems fine.

flotho · 2021-11-05T13:54:11Z

ping @sbidoul , any chance to have an additional review

sbidoul · 2021-11-17T20:52:01Z

Sorry for the delay I've been very busy on other things. I'll get back to this as soon as I can. In the meantime can you look at the test failures?

sbidoul · 2021-12-04T11:22:40Z

Hi,

I had a quick look at the tests.

There is a pre-commit check failing. I recommend running pre-commit install in your local checkout so the pre-commit checks will run locally before pushing.
I would not worry about the failing test on 8.0. I think I'll drop python 2 support. The previous versions will still be there for those who need it.
You need to investigate the test failures on Odoo 13,14,15

flotho · 2021-12-30T16:49:15Z

Hi @sbidoul a great thanks for this feedback

flotho · 2021-12-30T16:53:25Z

@gaelTorrecillas @MAG-Florian-Chevalier could you have a look to this please

takuyozora · 2024-06-15T12:02:43Z

Hi, this PR could be really useful, any change that it will be merged soon ? Thanks !

omerahmed1994 · 2024-11-19T13:53:46Z

Hi, this PR could be really useful, any change that it will be merged soon ? Thanks !

+1

sbidoul · 2024-11-19T14:43:41Z

I had lost track of this, sorry for the delay.

This would need tests.

Also, I think there should be a warning or an error (not sure) if these new options are used with --cache, otherwise they will be silently ignored and that will be confusing for users.

add user and lang options

1e18b5d

add new params for initdb. add login password lang and country (#1)

3f8750b

* add new params for initdb. add login password lang and country * fix no cache with specific modules * fix no cache with specific modules

MAG-Florian-Chevalier marked this pull request as ready for review October 15, 2021 12:17

MAG-Florian-Chevalier changed the title ~~[WIP] add user and lang options~~ add user and lang options Oct 15, 2021

MAG-Florian-Chevalier changed the title ~~add user and lang options~~ [initdb] add user and lang options Oct 15, 2021

sbidoul reviewed Oct 15, 2021

View reviewed changes

MAG-Florian-Chevalier and others added 2 commits October 22, 2021 15:47

fix odoo_createdb_without_cache and default country

29f1468

remove phone (odoo 10 does not support phone in arguments) (#2)

e58526f

MAG-Florian-Chevalier added 2 commits January 14, 2022 15:14

update default lang

97f2677

update default lang

46af7d8

gaelTorrecillas approved these changes Jan 14, 2022

View reviewed changes

run precommit

5410eb0

gaelTorrecillas approved these changes Jan 14, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[initdb] add user and lang options #101

[initdb] add user and lang options #101

MAG-Florian-Chevalier commented Sep 10, 2021

MAG-Florian-Chevalier commented Sep 10, 2021

codecov-commenter commented Sep 11, 2021 •

edited

Loading

flotho commented Sep 24, 2021

sbidoul commented Sep 24, 2021

flotho commented Sep 24, 2021

MAG-Florian-Chevalier commented Oct 15, 2021

sbidoul left a comment

sbidoul Oct 15, 2021

sbidoul Oct 15, 2021

sbidoul Oct 15, 2021

flotho commented Oct 18, 2021

sbidoul commented Oct 18, 2021

flotho commented Oct 19, 2021

MAG-Florian-Chevalier commented Oct 22, 2021

flotho commented Nov 5, 2021

sbidoul commented Nov 17, 2021

sbidoul commented Dec 4, 2021

flotho commented Dec 30, 2021

flotho commented Dec 30, 2021

takuyozora commented Jun 15, 2024

omerahmed1994 commented Nov 19, 2024

sbidoul commented Nov 19, 2024

[initdb] add user and lang options #101

Are you sure you want to change the base?

[initdb] add user and lang options #101

Conversation

MAG-Florian-Chevalier commented Sep 10, 2021

MAG-Florian-Chevalier commented Sep 10, 2021

codecov-commenter commented Sep 11, 2021 • edited Loading

Codecov Report

flotho commented Sep 24, 2021

sbidoul commented Sep 24, 2021

flotho commented Sep 24, 2021

MAG-Florian-Chevalier commented Oct 15, 2021

sbidoul left a comment

Choose a reason for hiding this comment

sbidoul Oct 15, 2021

Choose a reason for hiding this comment

sbidoul Oct 15, 2021

Choose a reason for hiding this comment

sbidoul Oct 15, 2021

Choose a reason for hiding this comment

flotho commented Oct 18, 2021

sbidoul commented Oct 18, 2021

flotho commented Oct 19, 2021

MAG-Florian-Chevalier commented Oct 22, 2021

flotho commented Nov 5, 2021

sbidoul commented Nov 17, 2021

sbidoul commented Dec 4, 2021

flotho commented Dec 30, 2021

flotho commented Dec 30, 2021

takuyozora commented Jun 15, 2024

omerahmed1994 commented Nov 19, 2024

sbidoul commented Nov 19, 2024

codecov-commenter commented Sep 11, 2021 •

edited

Loading