Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added comments to flag unsuitable tests for OpenJ9 #1295

Merged
merged 12 commits into from
Aug 22, 2019
Merged

Added comments to flag unsuitable tests for OpenJ9 #1295

merged 12 commits into from
Aug 22, 2019

Conversation

M-Davies
Copy link
Contributor

Also updated issue weblinks

smlambert
smlambert reviewed Aug 22, 2019
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will rather deal with these permanent exclusions under a single openjdk-tests issue "Non-applicable tests for implementation" and update the url in the excludes file.

@M-Davies
Copy link
Contributor Author

Will update to reference this issue #1297

smlambert
smlambert approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update @M-Davies !

@smlambert smlambert merged commit cb90396 into adoptium:master Aug 22, 2019
@M-Davies M-Davies deleted the comments branch August 22, 2019 14:22
@karianna karianna added the bug label Aug 24, 2019
@karianna karianna added this to the August 2019 milestone Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
August 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@M-Davies @smlambert @karianna