Excluding some of the JDK17 tests on z/OS #4567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karianna
approved these changes
May 9, 2023
|
@llxia Could you please review this PR. Thank you. |
llxia
reviewed
May 11, 2023
| @@ -234,9 +235,15 @@ java/nio/channels/DatagramChannel/Loopback.java https://github.ibm.com/runtimes/ | |||
| #java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java https://github.com/adoptium/infrastructure/issues/699 linux-s390x | |||
| java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java https://github.com/adoptium/aqa-tests/issues/1267 macosx-all,linux-s390x | |||
| #java/nio/channels/DatagramChannel/Promiscuous.java is excluded on macosx due to different issue https://github.com/eclipse-openj9/openj9/issues/6669 | |||
| java/nio/channels/DatagramChannel/Promiscuous.java https://github.com/adoptium/infrastructure/issues/699 linux-s390x,macosx-all | |||
| java/nio/channels/DatagramChannel/Promiscuous.java https://github.com/adoptium/infrastructure/issues/699 linux-s390x,macosx-all,z/OS-s390x | |||
There was a problem hiding this comment.
Please leave a comment on why this test is excluded from zOS.
There was a problem hiding this comment.
Tests which are excluded on JDK11 also to be excluded for JDK17.
https://github.com/adoptium/aqa-tests/blob/master/openjdk/excludes/ProblemList_openjdk11-openj9.txt#L230
There was a problem hiding this comment.
More details on this exclusion been mentioned here runtimes/openj9-openjdk-jdk17-zos/issues/383
| @@ -161,6 +161,7 @@ com/sun/management/DiagnosticCommandMBean/DcmdMBeanDoubleInvocationTest.java htt | |||
| com/sun/management/DiagnosticCommandMBean/DcmdMBeanInvocationTest.java https://github.com/adoptium/aqa-tests/issues/1297 generic-all | |||
| com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java https://github.com/adoptium/aqa-tests/issues/1297 generic-all | |||
| com/sun/management/DiagnosticCommandMBean/DcmdMBeanTest.java https://github.com/adoptium/aqa-tests/issues/1297 generic-all | |||
| com/sun/management/OperatingSystemMXBean/GetFreePhysicalMemorySize.java https://github.com/adoptium/aqa-tests/issues/1297 z/OS-s390x | |||
There was a problem hiding this comment.
I do not see any reference to this test in #1297
| java/nio/channels/FileChannel/directio/PwriteDirect.java https://github.com/adoptium/aqa-tests/issues/1297 z/OS-s390x | ||
| java/nio/channels/FileChannel/TempDirectBuffersReclamation.java https://github.com/adoptium/aqa-tests/issues/1297 z/OS-s390x | ||
| java/nio/channels/FileChannel/directio/WriteDirect.java https://github.com/adoptium/aqa-tests/issues/1297 z/OS-s390x | ||
| java/nio/channels/Selector/OutOfBand.java https://github.com/adoptium/aqa-tests/issues/1297 z/OS-s390x |
There was a problem hiding this comment.
I do not see any reference to the tests in #1297
llxia
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excluding some of the JDK17 tests on z/OS which includes both temporary and permanent exclusions.
For more details refer :- #1297 (comment)
Temporary exclusions refer :- #4566