Handle missing classes.jar in sharedClassesTestData #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Grinder runs:
After change:
|
llxia
reviewed
Dec 2, 2024
| FileRef sharedClassesJar = sharedClassesDataDir.childFile("classes.jar"); | ||
| if (sharedClassesJar.exists()) { | ||
| System.out.println(sharedClassesDataDir.getSpec() + " exists and contains classes.jar"); | ||
| found = 1; |
Comment on lines
212
to
213
| Path sharedClassesDataDirPath = sharedClassesDataDir.asJavaFile().toPath(); | ||
| removeAllContentsAndDeleteDir(sharedClassesDataDirPath); |
There was a problem hiding this comment.
These lines were added to ensure that the directory sharedClassesDataDir and all its contents are deleted before proceeding with the creation of source files and classes.jar.Otherwise it was resulting in an exception as shown below:
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/45365/consoleFull
Generating jar files in /home/jenkins/testDependency/system_lib/sharedClassesTestData/v1/jdk11
11:45:36 CSC 02/12/24 08:45:36: Creating source files
11:45:36 CSC stderr Exception in thread "main" java.lang.RuntimeException: Failed to create destination directory for source files
11:45:36 CSC stderr at net.openj9.test.sc.JavaGen.makeJavas(JavaGen.java:132)
11:45:36 CSC stderr at net.openj9.test.sc.JavaGen.go(JavaGen.java:100)
11:45:36 CSC stderr at net.openj9.test.sc.JavaGen.main(JavaGen.java:94)
11:45:36 STF 08:45:36.289 - **FAILED** Process CSC ended with exit code (1) and not the expected exit code/s (0)
11:45:36 STF 08:45:36.289 - Monitoring Report Summary:
Thinking it might be due to corrupt or residual files already present in the directory.
llxia
reviewed
Dec 2, 2024
openj9.test.sharedClasses/src/test.sharedClasses/net/openj9/stf/SharedClasses.java
Outdated
Show resolved
Hide resolved
annaibm
force-pushed
the
sharedClassCheck
branch
from
f887dff to
a21d256
Compare
llxia
reviewed
Dec 4, 2024
| System.out.println(sharedClassesDataDir.getSpec() + " exists"); | ||
| FileRef sharedClassesJar = sharedClassesDataDir.childFile("classes.jar"); | ||
| if (sharedClassesJar.exists()) { | ||
| System.out.println(sharedClassesDataDir.getSpec() + " exists and contains classes.jar"); | ||
| found = 1; |
annaibm
force-pushed
the
sharedClassCheck
branch
from
ee6468b to
6864d0d
Compare
|
In PR description, please change the keyword |
annaibm
force-pushed
the
sharedClassCheck
branch
from
6864d0d to
9960dde
Compare
llxia
reviewed
Dec 4, 2024
| } | ||
| break; | ||
| } else { | ||
| System.out.println(sharedClassesDataDir.getSpec() + " exists but classes.jar does not exist"); |
There was a problem hiding this comment.
Change it to sharedClassesDataDir.getSpec() + "/classes.jar does not exist.
- ensure the presence of classes.jar , if doesnt exist regenerate it. resolves: eclipse-openj9/openj9#19582 Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm
force-pushed
the
sharedClassCheck
branch
from
ba9e861 to
a0c6914
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: eclipse-openj9/openj9#19582