make the right comparaison for the PR results

[adrienpessu]

This pull request primarily focuses on refactoring and enhancing the functionality of the Sarif Viewer tool. The changes include updates to the SarifService and SarifViewerWindowFactory classes, the addition of a new data class, and a minor version update for the plugin.

Here are the key changes:

1. Plugin Version Update:

   • gradle.properties: Updated the pluginUntilBuild version from 232.* to 233.*.

2. New Data Class Addition:

   • src/main/kotlin/com/github/adrienpessu/sarifviewer/models/BranchItemComboBox.kt: Added a new data class BranchItemComboBox to hold information about the pull request number, head, base, PR title, and commit.

3. Updates to SarifService Class:

   • src/main/kotlin/com/github/adrienpessu/sarifviewer/services/SarifService.kt: Several changes were made to this class, including importing new modules, refactoring the loadSarifFile method to getSarifFromGitHub which now returns a list of SarifSchema210 objects, and adding a new analyseResult function to process a list of Result objects. [1] [2] [3] [4] [5]

4. Updates to SarifViewerWindowFactory Class:

   • src/main/kotlin/com/github/adrienpessu/sarifviewer/toolWindow/SarifViewerWindowFactory.kt: This class saw a series of changes including the addition of new imports, the replacement of selectList with comboBranchPR of type BranchItemComboBox, refactoring of the loadDataAndUI method to include a selectedCombo parameter, and significant updates to the extractSarif and populateCombo methods to accommodate these changes. [1] [2] [3] [4] [5] [6] [7] [8]

[github-actions]

Qodana Community for JVM

33 new problems were found

Inspection name	Severity	Problems
Unused symbol	🔶 Warning	4
Incorrect string capitalization	🔶 Warning	2
Redundant SAM constructor	🔶 Warning	2
Local 'var' is never modified and can be declared as 'val'	🔶 Warning	1
Accessor call that can be replaced with property access syntax	◽️ Notice	7
Property naming convention	◽️ Notice	6
Object literal can be converted to lambda	◽️ Notice	5
Can be replaced with binary operator	◽️ Notice	3
Unnecessary parentheses in function call with lambda	◽️ Notice	2
Return or assignment can be lifted out	◽️ Notice	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

1. Register at Qodana Cloud and configure the action
2. Use GitHub Code Scanning with Qodana
3. Host Qodana report at GitHub Pages
4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions