Skip to content

Commit

Permalink
Rename XSJS packs to remove async qualifier
Browse files Browse the repository at this point in the history
We support the non-async versions of XSJS, so rename the packs for
clarity.
  • Loading branch information
lcartey committed Nov 20, 2024
1 parent 04acfd8 commit 69ea4ed
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/javascript.sarif.expected

Large diffs are not rendered by default.

7 changes: 5 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ jobs:
- name: Perform CodeQL Analysis
id: analyze
uses: github/codeql-action/analyze@v3
env:
LGTM_INDEX_XML_MODE: all
LGTM_INDEX_FILETYPES: ".json:JSON\n.cds:JSON"
```
Example configuration file:
```yaml
Expand All @@ -50,7 +53,7 @@ packs:
# Use these packs for JavaScript and TypeScript analysis
javascript:
- codeql/javascript-queries:codeql-suites/javascript-security-extended.qls
- advanced-security/javascript-sap-async-xsjs-queries:codeql-suites/javascript-security-extended.qls
- advanced-security/javascript-sap-xsjs-queries:codeql-suites/javascript-security-extended.qls
- advanced-security/javascript-sap-cap-queries:codeql-suites/javascript-security-extended.qls
- advanced-security/javascript-sap-ui5-queries:codeql-suites/javascript-security-extended.qls

Expand Down Expand Up @@ -84,7 +87,7 @@ codeql database create <DB_NAME> --language=javascript
codeql database analyze <DB_NAME> --format=sarif-latest --output=<OUTPUT_FILE> \
--download advanced-security/javascript-sap-cap-queries \
advanced-security/javascript-sap-ui5-queries \
advanced-security/javascript-sap-async-xsjs-queries
advanced-security/javascript-sap-xsjs-queries
```

## License
Expand Down
2 changes: 1 addition & 1 deletion javascript/frameworks/xsjs/ext/qlpack.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
library: true
name: advanced-security/javascript-sap-async-xsjs-models
name: advanced-security/javascript-sap-xsjs-models
version: 0.1.0
extensionTargets:
codeql/javascript-all: "^2.0.0"
Expand Down
2 changes: 1 addition & 1 deletion javascript/frameworks/xsjs/lib/qlpack.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
library: true
name: advanced-security/javascript-sap-async-xsjs-lib
name: advanced-security/javascript-sap-xsjs-lib
version: 0.1.0
suites: codeql-suites
extractor: javascript
Expand Down
6 changes: 3 additions & 3 deletions javascript/frameworks/xsjs/src/qlpack.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
---
library: false
name: advanced-security/javascript-sap-async-xsjs-queries
name: advanced-security/javascript-sap-xsjs-queries
version: 0.1.0
suites: codeql-suites
extractor: javascript
dependencies:
codeql/javascript-all: "^2.0.0"
advanced-security/javascript-sap-async-xsjs-models: "^0.1.0"
advanced-security/javascript-sap-async-xsjs-lib: "^0.1.0"
advanced-security/javascript-sap-xsjs-models: "^0.1.0"
advanced-security/javascript-sap-xsjs-lib: "^0.1.0"
default-suite-file: codeql-suites/javascript-code-scanning.qls
6 changes: 3 additions & 3 deletions javascript/frameworks/xsjs/test/qlpack.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
name: advanced-security/javascript-sap-async-xsjs-tests
name: advanced-security/javascript-sap-xsjs-tests
version: 0.1.0
extractor: javascript
dependencies:
codeql/javascript-all: "^2.0.0"
advanced-security/javascript-sap-async-xsjs-queries: "^0.1.0"
advanced-security/javascript-sap-async-xsjs-lib: "^0.1.0"
advanced-security/javascript-sap-xsjs-queries: "^0.1.0"
advanced-security/javascript-sap-xsjs-lib: "^0.1.0"

0 comments on commit 69ea4ed

Please sign in to comment.