Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stubbing out the aep tooling list #238

Merged
merged 6 commits into from
Jan 11, 2025
Merged

Stubbing out the aep tooling list #238

merged 6 commits into from
Jan 11, 2025

Conversation

earth2marsh
Copy link
Contributor

will update links after #231 is addressed

🍱 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes
that apply

  • Enhancement
  • New proposal
  • Migrated from google.aip.dev
  • Chore / Quick Fix

will update links after #231 is addressed
@earth2marsh earth2marsh requested a review from a team as a code owner November 2, 2024 00:26
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Mostly areas for discussion - I think I'm negotiable on all of them. Curious about your thoughts.

config/hero.yaml Outdated Show resolved Hide resolved
config/hero.yaml Outdated Show resolved Hide resolved
config/hero.yaml Outdated Show resolved Hide resolved
pages/general/adopting.md Outdated Show resolved Hide resolved
pages/general/adopting.md Outdated Show resolved Hide resolved
pages/general/adopting.md Outdated Show resolved Hide resolved
pages/general/faq.md Outdated Show resolved Hide resolved
pages/general/faq.md Outdated Show resolved Hide resolved
pages/general/faq.md Outdated Show resolved Hide resolved
pages/general/faq.md Outdated Show resolved Hide resolved
@toumorokoshi toumorokoshi added this to the GA milestone Nov 5, 2024
thanks, agree with all these suggestions and just layered in some minor tweaks to the suggestions.

Co-authored-by: Yusuke Tsutsumi <[email protected]>
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more nits, but otherwise LGTM! thank you.

config/hero.yaml Outdated Show resolved Hide resolved
pages/general/adopting.md Outdated Show resolved Hide resolved
pages/general/adopting.md Outdated Show resolved Hide resolved
@toumorokoshi toumorokoshi merged commit f654697 into main Jan 11, 2025
2 checks passed
@toumorokoshi toumorokoshi deleted the repo-reorg branch January 11, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants