Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TOOLS-2693 add ldap return codes #216

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

jdogmcsteezy
Copy link

No description provided.

@jdogmcsteezy jdogmcsteezy self-assigned this Oct 12, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (938caae) 68.75% compared to head (bcf2270) 68.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
- Coverage   68.75%   68.74%   -0.01%     
==========================================
  Files          91       91              
  Lines       21247    21262      +15     
==========================================
+ Hits        14608    14617       +9     
- Misses       6639     6645       +6     
Files Coverage Δ
lib/live_cluster/client/types.py 98.02% <100.00%> (+0.15%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdogmcsteezy jdogmcsteezy merged commit eb7b4b1 into master Oct 17, 2023
4 checks passed
@jdogmcsteezy jdogmcsteezy deleted the TOOLS-2693-ldap-err-codes branch October 17, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants