Om 191 #115
Merged
Om 191 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added github action to upload tar.gz and zip artefacts to release tag
kept only zip files ( & removed tar.gz files of dashboards) modified zip filename with pattern aerospike-grafana-dashboard-<version>.zip
updated artefact as tar.gz files
sunilvirus
reviewed
May 9, 2024
| cd config/grafana | ||
| echo "Tar & GZipping tar files" | ||
| VERSION=${GITHUB_REF_NAME#v} | ||
| tar cvf aerospike-grafana-dashboards-$VERSION.tar dashboards/* |
There was a problem hiding this comment.
Why not single step with 'tar czf' ?
sunilvirus
reviewed
May 9, 2024
| # echo "tag_name $TAG_NAME" | ||
| echo | ||
|
|
||
| files=$(find config/grafana -type f -name "aerospike-grafana-dashboards*" -printf "$(realpath -s %p) ") |
There was a problem hiding this comment.
You know the exact path. why find ?
removed unnecessary code
unified tar and gzip in single step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added GitHub action to create and upload aerospike-grafana-dashboards-$VERSION.tar.gz to GitHub release tags