Add logic to force the min date return #1
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YannickGagnon
requested changes
Jan 9, 2025
Comment on lines
+193
to
+197
| if (firstDayOfWeek < week) { | ||
| return week; | ||
| } else { | ||
| return lastDayOfWeek; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (firstDayOfWeek < week) { | |
| return week; | |
| } else { | |
| return lastDayOfWeek; | |
| } | |
| if (lastDayOfWeek < week) { | |
| return week; | |
| } else { | |
| return lastDayOfWeek; | |
| } |
Comment on lines
+210
to
+214
| if (firstDayOfWeek < week) { | ||
| return week; | ||
| } else { | ||
| return middleDayOfWeek; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (firstDayOfWeek < week) { | |
| return week; | |
| } else { | |
| return middleDayOfWeek; | |
| } | |
| if (middleDayOfWeek < week) { | |
| return week; | |
| } else { | |
| return middleDayOfWeek; | |
| } |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lorsque nous utilisons le voice over, il y a un crash causé par un bug dans la logique de calcul du premier jour de l'intervalle du FSCalendar. Alors, comme avec le voice over la date sélectionnée automatiquement est la date minimale de l'intervalle de la bibliothèque, mais dans ces fonctions le calcul finit par créer une date invalide 1969/12/29, causant un crash avec ce message d'erreur 'FSCalendar date out of bounds exception', reason: 'Target date 1969/12/29 beyond bounds [1970/01/01 - 2099/12/31]'.