Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestUtils key값을 enum class로 받도록 수정 #299

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

hwgyun
Copy link
Collaborator

@hwgyun hwgyun commented Dec 13, 2024

📚 개요

#298

@hwgyun hwgyun added the 🛠 Refactor 리팩토링 관련 라벨입니다. label Dec 13, 2024
@hwgyun hwgyun self-assigned this Dec 13, 2024
Copy link
Collaborator

@discphy discphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

내장 클래스 말고 클래스 자체를 분리하는건 어떨까요? 🤔

@@ -4,16 +4,20 @@ import org.springframework.web.context.request.RequestAttributes
import org.springframework.web.context.request.RequestContextHolder

class RequestUtils {
enum class Attribute (val key: String) {
MEMBER_ID("memberId")
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 별도 이넘 클래스로 만드신 이유가 있을까요? 👀
그냥 static 변수로 선언하고 RequestUtils.MEMBER_ID_KEY 처럼 바로 접근해도 좋을 것 같아서요!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 Refactor 리팩토링 관련 라벨입니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants