Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] test and fix oops #9

Merged
merged 7 commits into from
Dec 8, 2023
Merged

[wip] test and fix oops #9

merged 7 commits into from
Dec 8, 2023

Conversation

ahdinosaur
Copy link
Owner

@ahdinosaur ahdinosaur commented Dec 7, 2023 •
edited
Loading

  • port tests from pull-box-stream
  • fix anything that fails tests
    • handle stream chunks > max content length
    • max content length is (2^16 - 1), not (2^16)
    • content length is encoded as uint, not int

@ahdinosaur ahdinosaur merged commit 38b34a3 into main Dec 8, 2023
2 checks passed
@ahdinosaur ahdinosaur deleted the test-and-fix-oops branch December 8, 2023 09:50
ahdinosaur added a commit that referenced this pull request Dec 8, 2023
@ahdinosaur
test and fix oops (#9)
3a2d6bb 
- port tests from `pull-box-stream`
- fix anything that fails tests
  - handle stream chunks > max content length
  - max content length is (2^16 - 1), not (2^16)
  - content length is encoded as uint, not int
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ahdinosaur