Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle interupt signal when runnning process #4658

Closed
wants to merge 1 commit into from
Closed

handle interupt signal when runnning process #4658

wants to merge 1 commit into from

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Jan 12, 2021

fix #4649

when running process from inside the interact shell the interrupt needed to be gracefully handled as in daemon runner, with cancel all tasks from loop and handle the interrupt signal with self.loop.add_signal_handler .

@unkcpz unkcpz requested a review from sphuber January 12, 2021 14:29
@unkcpz unkcpz mentioned this pull request Jan 12, 2021
Open
@unkcpz
Copy link
Member Author

unkcpz commented Jan 12, 2021 •
edited
Loading

BTW I think this also relevant to 'children processes are not killed with parent process' #4298 and #3776. But sadly not able to fix them. Anyway would be better to also have an eye on them while reviewing this pr.

@unkcpz
Copy link
Member Author

unkcpz commented Jan 12, 2021

Sorry, this is a wrong fix. needed cannot cancel all task before kill process.

@unkcpz unkcpz closed this Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphuber sphuber Awaiting requested review from sphuber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CTRL+C in new asyncio daemon while running a process does not kill it
1 participant
@unkcpz