Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rsync/graphviz executables and jedi for autocompeletion #6180

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Nov 16, 2023

  • rsync is needed for the new backup mechenism.
  • graphviz is needed for plot the provenance graph.
  • jedi was not a dependency which will make the IPython (verdi shell) autocompletion not work for node.inputs.<tab>.

@unkcpz unkcpz force-pushed the fix/xx/lack-of-tools-in-image branch from 0212473 to 4d8533c Compare November 16, 2023 16:15
@unkcpz unkcpz modified the milestones: v2.4.2, v2.5.0 Nov 16, 2023
@unkcpz
Copy link
Member Author

unkcpz commented Nov 16, 2023

I play around with the milestone because the issue comes with the docker image and I want to use milestone as a "wishlist".The milestones we used to have but not now actively used.
I want to use this PR to start a discussion on who should manage the milestones, when and how often should we make release and which should go to which release. If you think it is better to start a discourse topic for developers (we don't have a channel yet for those discussions), I'll open one to make it more general because me and @danielhollas just started a similar discussion for AiiDAlab.
Pinning @sphuber for comment.

@sphuber
Copy link
Contributor

sphuber commented Nov 16, 2023

Think a discourse topic is better suited than a PR, so please go ahead and open one. I will respond there

@unkcpz
Copy link
Member Author

unkcpz commented Nov 16, 2023

@sphuber
Copy link
Contributor

sphuber commented Nov 21, 2023

@unkcpz why do we need to install jedi explicitly as a dependency? We install ipython as a direct dependency and that in turn requires jedi:
https://github.com/ipython/ipython/blob/6e37b96b9fa01c78cc529131038e1adc0343e606/setup.py#L188
https://github.com/ipython/ipython/blob/225a1a2699f328c1b4a0ded2de1f7af9f731ad55/setup.cfg#L35

@unkcpz
Copy link
Member Author

unkcpz commented Nov 21, 2023

Ah, yes, thanks for the correction. The autocompletion is not working when IPython==8.17.2 and jedi==0.19.1. In fact, it is the node inputs not able to autocomplete the attributes. I downgraded the jedi to 0.18.2 and it works.
I think this requires more investigation. I guess it is also reproducible in the local aiida installation. Can you give it a try to specifically install these two versions of dependencies see if you can reproduce it?

@unkcpz
Copy link
Member Author

unkcpz commented Nov 21, 2023

I think this is the issue related davidhalter/jedi#1962 (a problem for __call__, but for us it is the attributes), if so I think we need to ping the jedi<0.19.

@sphuber
Copy link
Contributor

sphuber commented Nov 21, 2023

I think this is the issue related davidhalter/jedi#1962 (a problem for __call__, but for us it is the attributes), if so I think we need to ping the jedi<0.19.

Good detective work. I can confirm that with jedi==0.19.1 it is broken but with jedi==0.18.0 it works. Fine for me to add the pin.

@unkcpz unkcpz force-pushed the fix/xx/lack-of-tools-in-image branch from 4d8533c to 43a602f Compare November 21, 2023 16:03
@unkcpz unkcpz requested a review from sphuber November 21, 2023 16:09
The former is used for the backup functionality and the latter is needed
to generate graphic representations of provenance graphs.
@sphuber sphuber force-pushed the fix/xx/lack-of-tools-in-image branch from 43a602f to f8a3e76 Compare November 21, 2023 18:35
Certain tab completion functionality in ipython shells, for example the
completion of `Node.inputs`, was broken for `jedi==0.19` in combination
with recent version of `ipython`.
@sphuber sphuber force-pushed the fix/xx/lack-of-tools-in-image branch from f8a3e76 to 57ec873 Compare November 21, 2023 21:02
@sphuber sphuber merged commit fae2a9c into aiidateam:main Nov 21, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants