-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚨🐛 Source Posthog: Require single project selection #50848
Open
domzae
wants to merge
5
commits into
airbytehq:master
Choose a base branch
from
domzae:domzae/source-posthog-individual-project-selection
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
🚨🐛 Source Posthog: Require single project selection #50848
domzae
wants to merge
5
commits into
airbytehq:master
from
domzae:domzae/source-posthog-individual-project-selection
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@domzae is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
octavia-squidington-iii
added
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
labels
Jan 2, 2025
domzae
temporarily deployed
to
community-ci-auto
January 2, 2025 16:37 — with
GitHub Actions
Inactive
domzae
had a problem deploying
to
community-ci-auto
January 2, 2025 16:55 — with
GitHub Actions
Error
domzae
temporarily deployed
to
community-ci-auto
January 2, 2025 16:57 — with
GitHub Actions
Inactive
marcosmarxm
requested a deployment
to
community-ci
January 10, 2025 14:25 — with
GitHub Actions
Waiting
marcosmarxm
requested a deployment
to
community-ci
January 10, 2025 14:25 — with
GitHub Actions
Waiting
marcosmarxm
temporarily deployed
to
community-ci-auto
January 10, 2025 14:25 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
community
connectors/source/posthog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #20868
Currently the connector connector pulls data from ALL projects available in Posthog. This is problematic if you have more than 1 project, as for example the events will dump all of the data together without a clear way to know which project an event came from.
Also fixes #33915 (solution from this comment)
How
project_id
as a required configCustomIncrementalSync
withDatetimeBasedCursor
components.py
by removing the now unnecessaryEventsCartesianProductStreamSlicer
classReview guide
manifest.yaml
components.py
User Impact
projects
stream is unaffected, and will always get all projects)project_id
in the source configurationCan this PR be safely reverted and rolled back?