Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨🐛 Source Posthog: Require single project selection #50848

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

domzae
Copy link
Contributor

@domzae domzae commented Jan 2, 2025

What

Fixes #20868
Currently the connector connector pulls data from ALL projects available in Posthog. This is problematic if you have more than 1 project, as for example the events will dump all of the data together without a clear way to know which project an event came from.

Also fixes #33915 (solution from this comment)

How

  • Add project_id as a required config
  • Replace CustomIncrementalSync with DatetimeBasedCursor
  • Simplify components.py by removing the now unnecessary EventsCartesianProductStreamSlicer class

Review guide

  1. manifest.yaml
  2. components.py

User Impact

  • User can now only get data from a single project per connector (projects stream is unaffected, and will always get all projects)
  • Breaking change: User will need to specify their project_id in the source configuration

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Jan 2, 2025

@domzae is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/posthog
Projects
None yet
3 participants