Bulk Load CDK: fix airbytevalue serialize #51044
Open
+83
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
edgao
commented
Jan 10, 2025
| is NullValue -> return "null" | ||
| // no idea why this is necessary, but jackson throws an exception if you try to serialize | ||
| // the ObjectValue directly | ||
| is ObjectValue -> return Jsons.writeValueAsString(this.values) |
There was a problem hiding this comment.
ugh, this doesn't even work b/c ObjectValue could contain a nested ObjectValue
edgao
force-pushed
the
edgao/fix_airbyte_value_serialize
branch
from
c524258 to
87a250a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://airbytehq-team.slack.com/archives/C03AS1GAQV6/p1736536510756639 and https://airbytehq-team.slack.com/archives/C081G34EA21/p1736538877457769
turns out we have a number of types that don't serialize how you'd expect, though null+object are the most egregious. Fix all of them.