This repository has been archived by the owner on Aug 30, 2024. It is now read-only.
Add sudo chown -R vscode:vscode ${ANDROID_HOME} to android-cli #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've briefly glanced over https://containers.dev/implementors/spec/, but cannot find anything. Let's just hard-code |
|
@vorburger let me know if this pr need to be reverted after testing |
|
@akhildevelops I've tested it, and it seem to work great! Thank You for merging this. |
Closed
|
Actually I spoke too soon - while I still think (hope) this will work, I think it would still need a release; see #9. |
|
@vorburger @akhildevelops |
vorburger
added a commit
to vorburger/devcontainer-features
that referenced
this pull request
Aug 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should, hopefully, fix #7.
I HAVE NOT (!) tested this specific change - I'm not sure how I could "locally" test a dev container feature?
I HAVE however tested manually running
sudo chown -R vscode:vscode /opt/android/in a Codespace AFTER install, and it helps.I don't know how to avoid hard-coding the
vscode:vscodeUID/GID in thechown... theinstall.shscript (clearly) runs asroot; I'm not sure if Dev Containers have some ENV var which specifies "the UID/GID under which the workspace will eventually run"?@akhildevelops would you be willing to merge this as-is? I can test it after you've merged it; great if it works, if it does not, we can revert it.
@jingtang10 FYI, this MAY fix google/android-fhir#2614.