Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename project to Kargo Render #185

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

krancour
Copy link
Member

@krancour krancour commented Oct 11, 2023

Fixes #181

This PR renames the project to Kargo Render.

The new configuration file (previously Bookfile.yaml) is kargo-render.yaml.

New package name is render, so some exported types like RenderRequest and RenderResponse got renamed to avoid the so-called "stutter" of render.RenderRequest, etc.

There are no functional changes in this PR.

Some non-code follow-up work may be required -- corresponding changes to CodeCov, Netlify, etc.

@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for docs-bookkeeper-akuity-io ready!

Name Link
🔨 Latest commit dbedf50
🔍 Latest deploy log https://app.netlify.com/sites/docs-bookkeeper-akuity-io/deploys/6526def74e63190008e0d3b7
😎 Deploy Preview https://deploy-preview-185.bookkeeper.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (9e77bc5) 38.28% compared to head (dbedf50) 38.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   38.28%   38.28%           
=======================================
  Files          19       19           
  Lines        1157     1157           
=======================================
  Hits          443      443           
  Misses        697      697           
  Partials       17       17           
Files Coverage Δ
cmd/action/request.go 100.00% <100.00%> (ø)
internal/helm/config.go 100.00% <ø> (ø)
internal/helm/helm.go 0.00% <ø> (ø)
internal/kustomize/config.go 100.00% <ø> (ø)
internal/kustomize/kustomize.go 25.00% <ø> (ø)
internal/ytt/config.go 100.00% <ø> (ø)
internal/ytt/ytt.go 0.00% <ø> (ø)
rendering.go 48.48% <ø> (ø)
validation.go 100.00% <100.00%> (ø)
prs.go 0.00% <0.00%> (ø)
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find any leftover bookkeeper references - LGTM!

@krancour
Copy link
Member Author

Holding for additional LGTM from @jessesuen

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krancour krancour merged commit e92d6d0 into akuity:main Oct 11, 2023
11 of 12 checks passed
This was referenced Oct 11, 2023
@krancour krancour deleted the krancour/kargo-render branch February 2, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename project to "kargo-render"
3 participants