Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 341 #342

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Fix 341 #342

merged 3 commits into from
Jan 3, 2024

Conversation

xiki-tempula
Copy link
Collaborator

Deprecate python 3.8 add support for python 3.12

@xiki-tempula xiki-tempula linked an issue Dec 30, 2023 that may be closed by this pull request
@xiki-tempula xiki-tempula mentioned this pull request Dec 30, 2023
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (862343b) 98.81% compared to head (9b95bfa) 98.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
- Coverage   98.81%   98.70%   -0.11%     
==========================================
  Files          28       28              
  Lines        1860     1860              
  Branches      402      402              
==========================================
- Hits         1838     1836       -2     
  Misses          2        2              
- Partials       20       22       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (will just adjust the CHANGELOG text)

CHANGES Outdated Show resolved Hide resolved
@orbeckst orbeckst merged commit 1360a0d into master Jan 3, 2024
9 of 11 checks passed
@orbeckst orbeckst deleted the 341-deprecate-python-38 branch January 3, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate python 3.8
2 participants