Skip to content

Commit

Permalink
fix: [spearbit-12] Typos (#12)
Browse files Browse the repository at this point in the history
  • Loading branch information
adam-alchemy authored and jaypaik committed Jan 25, 2024
1 parent b0921b6 commit 1b82012
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion src/account/AccountExecutor.sol
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ abstract contract AccountExecutor {
// - (32 bytes) Sender
// - (32 bytes) Value
// - (32 bytes) data offset
// Totoal: 164 bytes
// Total: 164 bytes
execCallBuffer := add(runtimeCallBuffer, 164)
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/account/AccountStorageInitializable.sol
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {AccountStorageV1} from "../libraries/AccountStorageV1.sol";
/// @title Account Storage Initializable
/// @author Alchemy
/// @notice This enables functions that can be called only once per implementation with the same storage layout
/// @dev Adapted from OpenZeppelin's Initialiazble and modified to use a diamond storage pattern. Removed
/// @dev Adapted from OpenZeppelin's Initializable and modified to use a diamond storage pattern. Removed
/// Initialized() event since the account already emits an event on initialization.
abstract contract AccountStorageInitializable is AccountStorageV1 {
error AlreadyInitialized();
Expand Down
6 changes: 3 additions & 3 deletions src/account/UpgradeableModularAccount.sol
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ contract UpgradeableModularAccount is
//
// 1. Check that the target is permitted at all, and if so check that any one of the following is true:
// a. Is any selector permitted?
// b. Is the calldata is empty? (allow empty data calls by default if the target address is permitted)
// b. Is the calldata empty? (allow empty data calls by default if the target address is permitted)
// c. Is the selector in the call permitted?
// 2. If the target is not permitted, instead check whether all external calls are permitted.
//
Expand All @@ -345,7 +345,7 @@ contract UpgradeableModularAccount is
revert ExecFromPluginExternalNotPermitted(callingPlugin, target, value, data);
}

// Run permitted call hooks and execution hooks. `execfuteFromPluginExternal` doesn't use PermittedCallData
// Run permitted call hooks and execution hooks. `executeFromPluginExternal` doesn't use PermittedCallData
// to check call permissions, nor do they have an address entry in SelectorData, so it doesn't make sense
// to use cached booleans (hasPreExecHooks, hasPostOnlyExecHooks, etc.) to conditionally bypass certain
// steps, as it would just be an added `sload` in the nonzero hooks case.
Expand Down Expand Up @@ -743,7 +743,7 @@ contract UpgradeableModularAccount is
}

// "Trim" the associated post hook arrays to the actual length, since we may have overallocated. This
// allows for exeuction of post hooks in reverse order.
// allows for execution of post hooks in reverse order.
assembly ("memory-safe") {
mstore(postHooks, actualPostHooksToRunLength)
mstore(postHookArgs, actualPostHooksToRunLength)
Expand Down
2 changes: 1 addition & 1 deletion src/interfaces/IPluginExecutor.sol
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ pragma solidity ^0.8.21;

/// @title Plugin Executor Interface
interface IPluginExecutor {
/// @notice Method from cals made from plugins to other plugin execution functions. Plugins are not allowed to
/// @notice Method from calls made from plugins to other plugin execution functions. Plugins are not allowed to
/// call accounts native functions.
/// @dev Permissions must be granted to the calling plugin for the call to go through
/// @param data The call data for the call.
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/AccountStorageV1.sol
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ contract AccountStorageV1 {
StoredInjectedHook[] injectedHooks;
}

/// @dev A version of IPliginManager.InjectedHook used to track injected hooks in storage. Omits the
/// @dev A version of IPluginManager.InjectedHook used to track injected hooks in storage. Omits the
/// hookApplyData field, which is not needed for storage, and flattens the struct.
struct StoredInjectedHook {
// The plugin that provides the hook
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ contract SessionKeyPermissionsPlugin is ISessionKeyPermissionsPlugin, SessionKey
// Multiplier for the verification gas limit is 3 if there is a paymaster, 1 otherwise.
// This is defined in EntryPoint v0.6.0, which uses the limit for the user op validation + paymaster
// validation, then again for up to two more calls of `postOp`. Later versions of the EntryPoint may
// change this scale factor or the usage of the verificaiton gas limit, so this value should be checked
// change this scale factor or the usage of the verification gas limit, so this value should be checked
// and updated if porting this plugin to a newer version of 4337.
uint256 multiplier = userOp.paymasterAndData.length > 0 ? 3 : 1;
uint256 maxGasFee = (
Expand Down Expand Up @@ -668,7 +668,7 @@ contract SessionKeyPermissionsPlugin is ISessionKeyPermissionsPlugin, SessionKey
// previous amount by more than the spending limit, then back up to the previous amount plus the
// spending limit.
}
// Unrecognzied function selector
// Unrecognized function selector
return 0;
}

Expand Down

0 comments on commit 1b82012

Please sign in to comment.