Skip to content

Commit

Permalink
fix: [S4] use Ownable2Step in AccountFactory
Browse files Browse the repository at this point in the history
  • Loading branch information
jaypaik committed Nov 21, 2024
1 parent 4027ce4 commit 25602b9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion gas-snapshots/ModularAccount.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"Runtime_AccountCreation": "176125",
"Runtime_AccountCreation": "176147",
"Runtime_BatchTransfers": "93045",
"Runtime_Erc20Transfer": "78454",
"Runtime_InstallSessionKey_Case1": "423148",
Expand Down
2 changes: 1 addition & 1 deletion gas-snapshots/SemiModularAccount.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"Runtime_AccountCreation": "97745",
"Runtime_AccountCreation": "97767",
"Runtime_BatchTransfers": "89031",
"Runtime_Erc20Transfer": "74488",
"Runtime_InstallSessionKey_Case1": "421700",
Expand Down
3 changes: 2 additions & 1 deletion src/factory/AccountFactory.sol
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ pragma solidity ^0.8.26;
import {ValidationConfigLib} from "@erc6900/reference-implementation/libraries/ValidationConfigLib.sol";
import {IEntryPoint} from "@eth-infinitism/account-abstraction/interfaces/IEntryPoint.sol";
import {Ownable} from "@openzeppelin/contracts/access/Ownable.sol";
import {Ownable2Step} from "@openzeppelin/contracts/access/Ownable2Step.sol";
import {IERC20} from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
import {SafeERC20} from "@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol";
import {LibClone} from "solady/utils/LibClone.sol";
Expand All @@ -15,7 +16,7 @@ import {SemiModularAccountBytecode} from "../account/SemiModularAccountBytecode.
/// @author Alchemy
/// @notice Factory contract to deploy modular accounts. Allows creation of both modular and semi-modular accounts
/// (the bytecode variant).
contract AccountFactory is Ownable {
contract AccountFactory is Ownable2Step {
ModularAccount public immutable ACCOUNT_IMPL;
SemiModularAccountBytecode public immutable SEMI_MODULAR_ACCOUNT_IMPL;
IEntryPoint public immutable ENTRY_POINT;
Expand Down

0 comments on commit 25602b9

Please sign in to comment.