fix: [spearbit-72] cache dependencies.length earlier (#40)

alchemyplatform · Jan 8, 2024 · 27fe9de · 27fe9de
1 parent c67dcb4
commit 27fe9de
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/account/PluginManagerInternals.sol b/src/account/PluginManagerInternals.sol
@@ -350,11 +350,11 @@ abstract contract PluginManagerInternals is IPluginManager, AccountStorageV1 {
         }
 
         // Check that the dependencies match the manifest.
-        if (dependencies.length != manifest.dependencyInterfaceIds.length) {
+        uint256 length = dependencies.length;
+        if (length != manifest.dependencyInterfaceIds.length) {
             revert InvalidDependenciesProvided();
         }
 
-        uint256 length = dependencies.length;
         for (uint256 i = 0; i < length;) {
             // Check the dependency interface id over the address of the dependency.
             (address dependencyAddr,) = dependencies[i].unpack();