fix: rename error IPluginInterfaceNotAllowed to InterfaceNotAllowed

alchemyplatform · Jan 29, 2024 · 2d3c9c8 · 2d3c9c8
1 parent 1194742
commit 2d3c9c8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/account/PluginManagerInternals.sol b/src/account/PluginManagerInternals.sol
@@ -67,10 +67,10 @@ abstract contract PluginManagerInternals is IPluginManager, AccountStorageV1 {
     error DuplicatePreUserOpValidationHookLimitExceeded(bytes4 selector, FunctionReference hook);
     error Erc4337FunctionNotAllowed(bytes4 selector);
     error ExecutionFunctionAlreadySet(bytes4 selector);
-    error IPluginFunctionNotAllowed(bytes4 selector);
-    error IPluginInterfaceNotAllowed();
+    error InterfaceNotAllowed();
     error InvalidDependenciesProvided();
     error InvalidPluginManifest();
+    error IPluginFunctionNotAllowed(bytes4 selector);
     error MissingPluginDependency(address dependency);
     error NativeFunctionNotAllowed(bytes4 selector);
     error NullFunctionReference();
@@ -456,7 +456,7 @@ abstract contract PluginManagerInternals is IPluginManager, AccountStorageV1 {
         for (uint256 i = 0; i < length; ++i) {
             bytes4 interfaceId = manifest.interfaceIds[i];
             if (interfaceId == type(IPlugin).interfaceId || interfaceId == _INVALID_INTERFACE_ID) {
-                revert IPluginInterfaceNotAllowed();
+                revert InterfaceNotAllowed();
             }
             storage_.supportedInterfaces[interfaceId] += 1;
         }

diff --git a/test/account/UpgradeableModularAccountPluginManager.t.sol b/test/account/UpgradeableModularAccountPluginManager.t.sol
@@ -263,7 +263,7 @@ contract UpgradeableModularAccountPluginManagerTest is Test {
         MockPlugin mockPluginBad = new MockPlugin(manifestBad);
         bytes32 manifestHashBad = keccak256(abi.encode(mockPluginBad.pluginManifest()));
 
-        vm.expectRevert(PluginManagerInternals.IPluginInterfaceNotAllowed.selector);
+        vm.expectRevert(PluginManagerInternals.InterfaceNotAllowed.selector);
         IPluginManager(account2).installPlugin({
             plugin: address(mockPluginBad),
             manifestHash: manifestHashBad,