fix: Cleanup comments, unused vars, config files. (#114)

.solhint-src.json

@@ -3,7 +3,7 @@
   "rules": {
     "immutable-vars-naming": ["error"],
     "no-unused-import": ["error"],
-    "compiler-version": ["error", ">=0.8.21"],
+    "compiler-version": ["error", ">=0.8.22"],
     "func-visibility": ["error", { "ignoreConstructors": true }],
     "max-line-length": ["error", 120],
     "func-param-name-mixedcase": ["error"],

.solhint-test.json

@@ -4,7 +4,7 @@
     "func-name-mixedcase": "off",
     "immutable-vars-naming": ["error"],
     "no-unused-import": ["error"],
-    "compiler-version": ["error", ">=0.8.21"],
+    "compiler-version": ["error", ">=0.8.22"],
     "func-visibility": ["error", { "ignoreConstructors": true }],
     "max-line-length": ["error", 120],
     "max-states-count": ["warn", 30],

script/Deploy.s.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;

slither.config.json

@@ -1,3 +1,3 @@
 {
-    "filter_paths": "lib"
+    "filter_paths": "(lib/|test/)"
 }

src/account/AccountExecutor.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;

src/account/AccountLoupe.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;

src/account/AccountStorageInitializable.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;

src/account/AccountStorageV1.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;
@@ -40,15 +40,15 @@ contract AccountStorageV1 {
         mapping(bytes24 => bool) callPermitted;
         // keys = address(calling plugin), target address
         mapping(IPlugin => mapping(address => PermittedExternalCallData)) permittedExternalCalls;
-        // For ERC165 introspection, each count indicates support from account or an installed plugin
-        // 0 indicate the account does not support the interface and all plugins that support this interface have
-        // been uninstalled
+        // For ERC165 introspection, each count indicates support from account or an installed plugin.
+        // 0 indicates the account does not support the interface and all plugins that support this interface have
+        // been uninstalled.
         mapping(bytes4 => uint256) supportedInterfaces;
     }
 
     struct PluginData {
         bool anyExternalAddressPermitted;
-        // boolean to indicate if the plugin can spend native tokens, if any of the execution function can spend
+        // A boolean to indicate if the plugin can spend native tokens, if any of the execution function can spend
         // native tokens, a plugin is considered to be able to spend native tokens of the accounts
         bool canSpendNativeToken;
         bytes32 manifestHash;

src/account/PluginManagerInternals.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;

src/account/UpgradeableModularAccount.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;
@@ -86,7 +86,6 @@ contract UpgradeableModularAccount is
     event ModularAccountInitialized(IEntryPoint indexed entryPoint);
 
     error AlwaysDenyRule();
-    error AuthorizeUpgradeReverted(bytes revertReason);
     error ExecFromPluginNotPermitted(address plugin, bytes4 selector);
     error ExecFromPluginExternalNotPermitted(address plugin, address target, uint256 value, bytes data);
     error NativeTokenSpendingNotPermitted(address plugin);

src/factory/MultiOwnerMSCAFactory.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;

src/factory/MultiOwnerTokenReceiverMSCAFactory.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;

src/helpers/CastLib.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;

src/helpers/FactoryHelpers.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;

src/helpers/FunctionReferenceLib.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;

src/helpers/KnownSelectors.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;

src/helpers/ValidationDataHelpers.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;

src/interfaces/IAccountInitializable.sol

@@ -4,7 +4,7 @@ pragma solidity ^0.8.22;
 /// @title Account Initializable Interface
 interface IAccountInitializable {
     /// @notice Initialize the account with a set of plugins.
-    /// @dev No dependencies or hooks can be injected with this installation.
+    /// @dev No dependencies may be provided with this installation.
     /// @param plugins The plugins to install.
     /// @param pluginInitData The plugin init data for each plugin.
     function initialize(address[] calldata plugins, bytes calldata pluginInitData) external;

src/libraries/AssociatedLinkedListSetLib.sol

@@ -466,7 +466,7 @@ library AssociatedLinkedListSetLib {
 
         // This segment is memory-safe because it only uses the scratch space memory after the value of the free
         // memory pointer.
-        // See https://docs.soliditylang.org/en/v0.8.21/assembly.html#memory-safety
+        // See https://docs.soliditylang.org/en/v0.8.22/assembly.html#memory-safety
         assembly ("memory-safe") {
             // Clean upper bits of arguments
             associated := and(associated, 0xffffffffffffffffffffffffffffffffffffffff)

src/libraries/LinkedListSetLib.sol

@@ -263,11 +263,11 @@ library LinkedListSetLib {
         // This is accomplished by first writing to memory after the free memory pointer,
         // then updating the free memory pointer to cover the newly-allocated data.
         // To the compiler, writes to memory after the free memory pointer are considered "memory safe".
-        // See https://docs.soliditylang.org/en/v0.8.21/assembly.html#memory-safety
+        // See https://docs.soliditylang.org/en/v0.8.22/assembly.html#memory-safety
         // Stack variable lifting done when compiling with via-ir will only ever place variables into memory
         // locations
         // below the current free memory pointer, so it is safe to compile this library with via-ir.
-        // See https://docs.soliditylang.org/en/v0.8.21/yul.html#memoryguard
+        // See https://docs.soliditylang.org/en/v0.8.22/yul.html#memoryguard
         assembly ("memory-safe") {
             // It is critical that no other memory allocations occur between:
             // -  loading the value of the free memory pointer into `ret`

src/plugins/BasePlugin.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;

src/plugins/TokenReceiverPlugin.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;

src/plugins/owner/IMultiOwnerPlugin.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;

src/plugins/owner/MultiOwnerPlugin.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;

src/plugins/session/ISessionKeyPlugin.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;
@@ -75,7 +75,6 @@ interface ISessionKeyPlugin {
     error LengthMismatch();
     error NativeTokenSpendLimitExceeded(address account, address sessionKey);
     error SessionKeyNotFound(address sessionKey);
-    error UnableToRemove(address sessionKey);
 
     // ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
     // ┃    Execution functions    ┃

src/plugins/session/SessionKeyPlugin.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;

src/plugins/session/permissions/ISessionKeyPermissionsUpdates.sol

@@ -9,10 +9,10 @@
 // option) any later version.
 //
 // This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
-// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
 // more details.
 //
-// You should have received a copy of the GNU General Public License along with this program.  If not, see
+// You should have received a copy of the GNU General Public License along with this program. If not, see
 // <https://www.gnu.org/licenses/>.
 
 pragma solidity ^0.8.22;