fix: [spearbit-86] store sessionKeyData.contractAccessControlType in …

…a local variable
alchemyplatform · Jan 8, 2024 · ae27491 · ae27491
1 parent 5493a3e
commit ae27491
Showing 1 changed file with 12 additions and 11 deletions.
diff --git a/src/plugins/session/permissions/SessionKeyPermissionsPlugin.sol b/src/plugins/session/permissions/SessionKeyPermissionsPlugin.sol
@@ -259,17 +259,18 @@ contract SessionKeyPermissionsPlugin is ISessionKeyPermissionsPlugin, SessionKey
 
         uint256 callsLength = calls.length;
         // Only return validation success when there is at least one call
-        bool validationSuccess = calls.length > 0;
-        for (uint256 i = 0; i < callsLength;) {
-            Call memory call = calls[i];
-            nativeTokenSpend += call.value;
-            validationSuccess = validationSuccess
-                && _checkCallPermissions(
-                    sessionKeyData.contractAccessControlType, keyId, call.target, call.value, call.data
-                );
-
-            unchecked {
-                ++i;
+        bool validationSuccess = callsLength > 0;
+        {
+            ContractAccessControlType accessControlType = sessionKeyData.contractAccessControlType;
+            for (uint256 i = 0; i < callsLength;) {
+                Call memory call = calls[i];
+                nativeTokenSpend += call.value;
+                validationSuccess = validationSuccess
+                    && _checkCallPermissions(accessControlType, keyId, call.target, call.value, call.data);
+
+                unchecked {
+                    ++i;
+                }
             }
         }