Skip to content

Commit

Permalink
style: fix typo (#122)
Browse files Browse the repository at this point in the history
  • Loading branch information
howydev committed Feb 1, 2024
1 parent f5d162c commit d2b9a04
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 1 deletion.
6 changes: 6 additions & 0 deletions src/factory/MultiOwnerMSCAFactory.sol
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ contract MultiOwnerMSCAFactory is Ownable2Step {
bytes32 internal immutable _MULTI_OWNER_PLUGIN_MANIFEST_HASH;
uint256 internal constant _MAX_OWNERS_ON_CREATION = 100;

error InvalidAction();
error InvalidOwner();
error OwnersArrayEmpty();
error OwnersLimitExceeded();
Expand Down Expand Up @@ -158,4 +159,9 @@ contract MultiOwnerMSCAFactory is Ownable2Step {
keccak256(abi.encodePacked(type(ERC1967Proxy).creationCode, abi.encode(IMPL, "")))
);
}

/// @notice Overriding to disable renounce ownership in Ownable
function renounceOwnership() public view override onlyOwner {
revert InvalidAction();
}
}
6 changes: 6 additions & 0 deletions src/factory/MultiOwnerTokenReceiverMSCAFactory.sol
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ contract MultiOwnerTokenReceiverMSCAFactory is Ownable2Step {
bytes32 internal immutable _TOKEN_RECEIVER_PLUGIN_MANIFEST_HASH;
uint256 internal constant _MAX_OWNERS_ON_CREATION = 100;

error InvalidAction();
error InvalidOwner();
error OwnersArrayEmpty();
error OwnersLimitExceeded();
Expand Down Expand Up @@ -166,4 +167,9 @@ contract MultiOwnerTokenReceiverMSCAFactory is Ownable2Step {
keccak256(abi.encodePacked(type(ERC1967Proxy).creationCode, abi.encode(IMPL, "")))
);
}

/// @notice Overriding to disable renounce ownership in Ownable
function renounceOwnership() public override onlyOwner {
revert InvalidAction();
}
}
2 changes: 1 addition & 1 deletion src/plugins/session/permissions/SessionKeyPermissions.sol
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ abstract contract SessionKeyPermissions is ISessionKeyPlugin, SessionKeyPermissi
revert InvalidPermissionsUpdate(updateSelector);
}

// If/else chain to find the right interal update function to perform.
// If/else chain to find the right internal update function to perform.
if (updateSelector == ISessionKeyPermissionsUpdates.setAccessListType.selector) {
ContractAccessControlType contractAccessControlType =
abi.decode(update[4:], (ContractAccessControlType));
Expand Down

0 comments on commit d2b9a04

Please sign in to comment.