fix: [spearbit-55] switch from .transfer to .call (#24)

alchemyplatform · Dec 22, 2023 · fd097ef · fd097ef
1 parent 4d4f76a
commit fd097ef
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/factory/MultiOwnerMSCAFactory.sol b/src/factory/MultiOwnerMSCAFactory.sol
@@ -24,6 +24,7 @@ contract MultiOwnerMSCAFactory is Ownable2Step {
     error OwnersArrayEmpty();
     error ZeroAddressOwner();
     error DuplicateOwner();
+    error TransferFailed();
 
     /// @notice Constructor for the factory
     constructor(
@@ -100,7 +101,10 @@ contract MultiOwnerMSCAFactory is Ownable2Step {
     /// @param amount amount of the token to withdraw in case of rebasing tokens
     function withdraw(address payable to, address token, uint256 amount) external onlyOwner {
         if (token == address(0)) {
-            to.transfer(address(this).balance);
+            (bool success,) = to.call{value: address(this).balance}("");
+            if (!success) {
+                revert TransferFailed();
+            }
         } else {
             SafeERC20.safeTransfer(IERC20(token), to, amount);
         }

diff --git a/src/factory/MultiOwnerTokenReceiverMSCAFactory.sol b/src/factory/MultiOwnerTokenReceiverMSCAFactory.sol
@@ -26,6 +26,7 @@ contract MultiOwnerTokenReceiverMSCAFactory is Ownable2Step {
     error OwnersArrayEmpty();
     error ZeroAddressOwner();
     error DuplicateOwner();
+    error TransferFailed();
 
     /// @notice Constructor for the factory
     constructor(
@@ -108,7 +109,10 @@ contract MultiOwnerTokenReceiverMSCAFactory is Ownable2Step {
     /// @param amount amount of the token to withdraw in case of rebasing tokens
     function withdraw(address payable to, address token, uint256 amount) external onlyOwner {
         if (token == address(0)) {
-            to.transfer(address(this).balance);
+            (bool success,) = to.call{value: address(this).balance}("");
+            if (!success) {
+                revert TransferFailed();
+            }
         } else {
             SafeERC20.safeTransfer(IERC20(token), to, amount);
         }