refactor: move FunctionReference type to IPluginManager #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypaik
force-pushed
the
01-22-refactor_move_FunctionReference_type_to_IPluginManager
branch
from
331c483 to
071e649
Compare
| return FunctionReference.unwrap(a) == FunctionReference.unwrap(b); | ||
| } | ||
| function isEmpty(FunctionReference fr) internal pure returns (bool) { | ||
| return FunctionReference.unwrap(fr) == bytes21(0); |
There was a problem hiding this comment.
Is Line 10 still necessary?
If so, we can refactor this line to use it to save a few wraps.
return fr == _EMPTY_FUNCTION_REFERENCE;
There was a problem hiding this comment.
Yes, FunctionReferenceLib._EMPTY_FUNCTION_REFERENCE is still being used in some places. Unfortunately can't use == to compare between these custom types since we no longer have the magic: using {eq as ==, notEq as !=} for FunctionReference global; being applied. :(
fangting-alchemy
approved these changes
Jan 23, 2024
jaypaik
deleted the
01-22-refactor_move_FunctionReference_type_to_IPluginManager
branch
jaypaik
added a commit
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a clean separation between CC0 interfaces and types (as defined in ERC-6900) and implementation-specific code.