fix: remove PluginIgnoredUninstallCallbackFailure event #111
+11
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangting-alchemy
approved these changes
Jan 23, 2024
Base automatically changed from
01-23-fix_update_interface_comments_and_pluginInitData_parameter_name
to
audit-2023-11-20
January 23, 2024 08:00
jaypaik
force-pushed
the
01-23-fix_remove_PluginIgnoredUninstallCallbackFailure_event
branch
from
f0c2b06 to
edcabd8
Compare
jaypaik
deleted the
01-23-fix_remove_PluginIgnoredUninstallCallbackFailure_event
branch
jaypaik
added a commit
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
event PluginIgnoredUninstallCallbackFailureis unnecessary now that we don't have hook unapply callbacks with the change from feat: remove permitted call hooks from MSCA (rebase on cache PR) #76. This also did not belong inIPluginManager. Removed.callbacksSucceededtoonUninstallSucceededsince there is just one callback now.