fix: [spearbit-32] Remove extra iteration for length check in AssociatedLinkedListSet #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypaik
approved these changes
Jan 23, 2024
| @@ -354,48 +354,60 @@ library AssociatedLinkedListSetLib { | |||
| /// @notice Gets all elements in a set. | |||
| /// @dev This is an O(n) operation, where n is the number of elements in the set. | |||
| /// @param set The set to get the elements of. | |||
| /// @return res An array of all elements in the set. | |||
| /// @return ret An array of all elements in the set. | |||
fangting-alchemy
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://github.com/spearbit-audits/alchemy-nov-review/issues/32
AssociatedLinkedListSetLibiterates over the set twice, once to get the length and once to collect the elements. However,LinkedListSetLibalready has an implementation that does not require an extra iteration over all elements, because the returned array is constructed as the elements are loaded. This causes an extra gas overhead forAssociatedLinkedListSetLib.Solution
Port over the logic from
LinkedListSetLib's implementation ofgetAlltoAssociatedLinkedListSetLib's implementation.Because the mapping lookups are handled differently due to the extra elements in the key buffer, we first convert the
TempBytesMemoryinto a type that is effectively a "bytes memory" by adding its size to the free memory pointer.