Rebase audit-2023-11-20 into main #120

jaypaik · 2024-01-25T00:13:54Z

Update: This is no longer relevant as we're using the develop branch now as our primary branch (previously named audit-2023-11-20)

~~To get back to linear history.~~

…ontract owners of MSCA (#15)

…n functions (#17)

… allow installPlugin and upgradeToAndCall (#22)

… and clean github lint action

…External (#29)

…into limitUsed and ignore existing approve amount (#28)

)

…luginStorageLib (#35)

…34)

…gth (#39)

…ossible (#98)

Co-authored-by: Jay Paik <[email protected]>

…cal OR operator (#64)

…elpers/ (#103)

…aries (#107)

…tedLinkedListSet (#115)

Co-authored-by: Jay Paik <[email protected]>

adam-alchemy and others added 30 commits December 11, 2023 14:41

style: run forge fmt (#11)

75e89b3

chore: setup deploy script and deploy to sepolia (#10)

009abaa

fix: [spearbit-12] Typos (#12)

2273cc9

fix: Remove variable shadowing and lint deploy script (#13)

b14e001

fix: [spearbit-76] Session key data storage collision (#14)

7e58e99

fix: [spearbit-38] ERC-1271 signature validation with EOA owners of c…

84f4b3d

…ontract owners of MSCA (#15)

fix: [spearbit-15] IPlugin function prevention in installing executio…

f70c9e5

…n functions (#17)

fix: [spearbit-34] Session key rotation registration check (#19)

bfb9b65

fix: Reorder CI elements to run forge fmt on the correct code (#21)

9d2fc29

fix: [spearbit-94] runtime validation bypass special case should only…

ef789cd

… allow installPlugin and upgradeToAndCall (#22)

fix: [quantstamp-20] clear plugin data early in uninstallPlugin (#25)…

10330fe

… and clean github lint action

fix: [spearbit-97] Prevent createAccount() user error (#26)

0619de5

fix: [spearbit-45] 2 step ownable factories (#23)

4d4f76a

fix: [spearbit-55] switch from .transfer to .call (#24)

fd097ef

fix: [quantstamp-3] add target is not self check in executeFromPlugin…

807823b

…External (#29)

fix: [quantstamp-1] sessionKey ERC20 spending limit to count approve …

1da79eb

…into limitUsed and ignore existing approve amount (#28)

fix: [spearbit-92] make gas limit validation reverts less expensive (#30

60ca631

)

fix: [spearbit-89] use newTotalUsage (#31)

43d71c6

fix: [quantstamp-1] sessionKey ERC20 spending limit comments update (#32

96f5fea

)

fix: [spearbit-99] Correctly set post-only hook flag (#20)

3e8944f

fix: [spearbit-95][quantstamp-9] disallow self-dependencies (#33)

4016fe8

fix: [spearbit-51][quantstamp-14] clean up upper bits of address in P…

dec1d76

…luginStorageLib (#35)

fix: [spearbit-54] use salt in eip-712 domain separator (#38)

662445a

fix: [quantstamp-6] add runtime deny pre hook for session key plugin (#…

2a22fbc

…34)

fix: [spearbit-25] Function initialize() can use calldata (#18)

596ad99

chore: add optimized-build profile (#36)

5d0816a

style: forge fmt and update foundry version in CI (#37)

be5f7d1

chore: bump foundry version (#44)

a46d9cb

fix: [spearbit-86-41] use cached variables accessControlType, callLen…

c67dcb4

…gth (#39)

fix: [spearbit-72] cache dependencies.length earlier (#40)

27fe9de

adam-alchemy and others added 28 commits January 22, 2024 15:16

fix: [spearbit-77] Refactor session key loading util functions (#93)

0d607ed

fix: [spearbit-56] update comments for factory withdraw functions (#96)

897387b

fix: [spearbit-40] Evaluate keccak expressions at compile time when p…

ec3c91d

…ossible (#98)

fix: [spearbit-65] make custom errors more informative (#94)

8f29800

refactor: move FunctionReference type to IPluginManager (#100)

2c99fcd

fix: [quantstamp-29] add comments for castlib functions (#101)

851c6cf

fix: [quantstamp-16] Disallow using dependencies for hooks (#77)

f258b31

fix: [spearbit-24] refactor _resolveManifestFunction (#97)

66377e3

fix: [spearbit-88] move SIG_VALIDATION_X to a global var (#73)

65547fc

Co-authored-by: Jay Paik <[email protected]>

fix: [spearbit-106] update comments to use bitwise OR instead of logi…

e4c6d97

…cal OR operator (#64)

refactor: libraries/AccountStorageV1 -> account/AccountStorageV1 (#102)

ac0ba48

refactor: libraries/CastLib.sol, libraries/FunctionReference.sol -> h…

b3ecbeb

…elpers/ (#103)

refactor: move test files to appropriate folders (#104)

28b44f7

refactor: sort imports (#105)

52a5577

chore: add license for libraries (#106)

266ea6f

chore: move license to root (#109)

8ccfd46

chore: add license for all other files outside of interfaces and libr…

6192189

…aries (#107)

chore: add license to interfaces (#110)

e68ad9a

fix: update interface comments and pluginInitData parameter name (#108)

a9da8fc

fix: remove PluginIgnoredUninstallCallbackFailure event (#111)

849f1ac

fix: obsolete comment within _doPreExecHooks (#112)

7b23932

style: removed unused const (#113)

80c8803

fix: Cleanup comments, unused vars, config files. (#114)

4199f10

fix: [spearbit-32] Remove extra iteration for length check in Associa…

f1c6a16

…tedLinkedListSet (#115)

chore: add doc for immutable entry point var (#116)

1c71be9

chore: update readme (#117)

1a6b5b7

Co-authored-by: Jay Paik <[email protected]>

chore: CC0 license update (#118)

6e7ee3f

chore: update comments (#119)

57a9f02

jaypaik merged commit 260eece into main Jan 25, 2024
3 checks passed

jaypaik deleted the audit-2023-11-20 branch January 25, 2024 00:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebase audit-2023-11-20 into main #120

Rebase audit-2023-11-20 into main #120

jaypaik commented Jan 25, 2024 •

edited

Loading

Rebase audit-2023-11-20 into main #120

Rebase audit-2023-11-20 into main #120

Conversation

jaypaik commented Jan 25, 2024 • edited Loading

jaypaik commented Jan 25, 2024 •

edited

Loading