Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [quantstamp-23] disable renounce ownership #123

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

howydev
Copy link
Collaborator

@howydev howydev commented Jan 26, 2024

Motivation

MSCA-23 Ownership Can Be Renounced

disable renounce ownership

@jaypaik jaypaik changed the title fix: disable renounce ownership fix: [quantstamp-23] disable renounce ownership Jan 26, 2024
@@ -43,6 +43,7 @@ contract MultiOwnerMSCAFactory is Ownable2Step {
error OwnersArrayEmpty();
error OwnersLimitExceeded();
error TransferFailed();
error InvalidAction();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nit: sort errors

@0xrubes
Copy link
Collaborator

0xrubes commented Jan 29, 2024

Looks good!

@howydev howydev merged commit 711a721 into howy/fix-typo Jan 29, 2024
3 checks passed
@howydev howydev deleted the howy/disable-renounce-ownership branch January 29, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants