fix: Remove variable shadowing and lint deploy script #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypaik
approved these changes
Dec 12, 2023
| @@ -128,19 +136,19 @@ contract Deploy is Script { | |||
| vm.stopBroadcast(); | |||
| } | |||
|
|
|||
| function _addStakeForFactory(address factoryAddr, IMSCAEntryPoint entryPoint) internal { | |||
| function _addStakeForFactory(address factoryAddr, IMSCAEntryPoint anEntryPoint) internal { | |||
There was a problem hiding this comment.
Don't feel strongly but slightly prefer postfixing with _ (e.g., entryPoint_) than the a or an prefixes. I know we have this elsewhere in the code though.
jaypaik
pushed a commit
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With the latest foundry update, the linter behavior has changed and the deploy script gets some changes.
Additionally, there's a compiler warning from a shadowed variable in the deploy script.
Solution
Lint the script and rename the shadowed variable to remove the compiler warning.