refactor: rename ContractAccessControlType.NONE to ALLOW_ALL_ACCESS #130
+27
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-alchemy
force-pushed
the
adam/naming-fixes
branch
from
3348dfe to
bb1cb92
Compare
howydev
pushed a commit
that referenced
this pull request
Feb 1, 2024
howydev
pushed a commit
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The enum value
NONEwithin the enum typeContractAccessControlTypeis used to describe "no access control"/"access control disabled", but semantically may be interpreted as "no addresses are permitted".Solution
To clarify the meaning of this enum value, rename it from
NONEtoALLOW_ALL_ACCESS.