Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add audit reports #131

Merged
merged 1 commit into from
Feb 1, 2024
Merged

feat: add audit reports #131

merged 1 commit into from
Feb 1, 2024

Conversation

jaypaik
Copy link
Collaborator

@jaypaik jaypaik commented Feb 1, 2024

Formatting the audit report file names as:
[short commit hash at which audit was conducted]_[ISO date of report delivery]_[vendor].pdf
[ISO date of report delivery]_[vendor]_[short commit hash at which audit was conducted].pdf

@jaypaik jaypaik requested a review from adam-alchemy February 1, 2024 19:06
Copy link
Contributor

@adam-alchemy adam-alchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: imo, we can leave the commit hash until the end, because the date and vendor are more important fields. So we could instead format the name as [ISO date of report delivery]_[vendor]_[short commit hash].pdf

@jaypaik
Copy link
Collaborator Author

jaypaik commented Feb 1, 2024

Nit: imo, we can leave the commit hash until the end, because the date and vendor are more important fields. So we could instead format the name as [ISO date of report delivery]_[vendor]_[short commit hash].pdf

Agreed re: importance. I sort of like the property of having audits conducted on the same commit clearly grouped together when ordered by filename (audit reports against the same commit may be delivered in different days). But a temporal ordering is nice, and 99% time they will be grouped the same way, so I'll change it!

@jaypaik jaypaik force-pushed the 02-01-feat_add_audit_reports branch from ae6333b to a4dda86 Compare February 1, 2024 21:18
@jaypaik jaypaik merged commit 645de7b into develop Feb 1, 2024
3 checks passed
@jaypaik jaypaik deleted the 02-01-feat_add_audit_reports branch February 1, 2024 21:25
howydev pushed a commit that referenced this pull request Feb 1, 2024
howydev pushed a commit that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants