Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve session key gas estimation #140

Merged
merged 6 commits into from
Feb 14, 2024
Merged

fix: improve session key gas estimation #140

merged 6 commits into from
Feb 14, 2024
+52 −42

Conversation

howydev
Copy link
Collaborator

@howydev howydev commented Feb 9, 2024

Motivation

  1. Revert when permission checks fail instead of SIG_VALIDATION_FAIL
  2. Do permissions checks when a dummy sig is used

@howydev howydev force-pushed the howy/update-sessionkey-checks branch from 7d9db25 to 255a2c9 Compare February 9, 2024 18:42
dphilipson
dphilipson approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@dphilipson dphilipson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left some small notes.

src/plugins/session/SessionKeyPlugin.sol Outdated Show resolved Hide resolved
src/plugins/session/SessionKeyPlugin.sol Outdated Show resolved Hide resolved
jaypaik
jaypaik reviewed Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@jaypaik jaypaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I like @dphilipson 's change requests

src/plugins/session/ISessionKeyPlugin.sol Show resolved Hide resolved
dphilipson
dphilipson approved these changes Feb 11, 2024
View reviewed changes
src/plugins/session/SessionKeyPlugin.sol Outdated Show resolved Hide resolved
@howydev howydev merged commit 8ae319e into develop Feb 14, 2024
3 checks passed
@howydev howydev deleted the howy/update-sessionkey-checks branch February 14, 2024 17:56
@howydev howydev restored the howy/update-sessionkey-checks branch February 20, 2024 18:00
@jaypaik jaypaik deleted the howy/update-sessionkey-checks branch February 20, 2024 23:37
jaypaik pushed a commit that referenced this pull request Feb 21, 2024
@howydev @jaypaik
fix: improve session key gas estimation (#140)
65f16dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rholterhus rholterhus rholterhus left review comments

@jaypaik jaypaik jaypaik left review comments

@gpersoon gpersoon gpersoon left review comments

@dphilipson dphilipson dphilipson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@howydev @dphilipson @gpersoon @jaypaik @rholterhus