Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: session key v1.0.1 deployments #142

Closed
wants to merge 3 commits into from

Conversation

howydev
Copy link
Collaborator

@howydev howydev commented Feb 14, 2024

No description provided.

Copy link
Contributor

@adam-alchemy adam-alchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things to update:

  • Could you change the PR name to the conventional commits format as "feat: session key v1.0.1 deployments"
  • Could you add address deployed at to the network files within deployments/, and link the run files and salt used?

@howydev howydev changed the title session key deployments feat: session key v1.0.1 deployments Feb 14, 2024
@howydev howydev requested a review from adam-alchemy February 14, 2024 19:25
@jaypaik
Copy link
Collaborator

jaypaik commented Feb 15, 2024

Is eth-goerli and opt-goerli purposely left out? Would like those in for completeness if possible! (unless we don't care about those networks anymore)

Also, it might be worth updating the rest of the contract deployments to add another row for 1.0.1 (just copying the 1.0.0) to reduce confusion. Or maybe changing 1.0.0 to 1.0.0-1.0.1 or something instead.

@howydev
Copy link
Collaborator Author

howydev commented Feb 15, 2024

goerli

@jaypaik i think they'll be deprecated soon so would say that goerlis are just a nice to have

Also, it might be worth updating the rest of the contract deployments to add another row for 1.0.1 (just copying the 1.0.0) to reduce confusion. Or maybe changing 1.0.0 to 1.0.0-1.0.1 or something instead.

good idea, will add

@jaypaik
Copy link
Collaborator

jaypaik commented Feb 18, 2024

Let's also verify that the most recent commits are included in this deployment.

@howydev howydev closed this Feb 20, 2024
@howydev howydev deleted the howy/deploy-session-key-feb2024 branch February 20, 2024 20:43
@howydev howydev restored the howy/deploy-session-key-feb2024 branch February 20, 2024 20:43
@howydev howydev deleted the howy/deploy-session-key-feb2024 branch February 20, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants