Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [spearbit-38] ERC-1271 signature validation with EOA owners of contract owners of MSCA #15

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

fangting-alchemy
Copy link
Collaborator

@fangting-alchemy fangting-alchemy changed the base branch from main to audit-2023-11-20 December 12, 2023 18:08
Copy link
Collaborator

@howydev howydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small nit, other than that LGTM

Copy link
Contributor

@adam-alchemy adam-alchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Two small requests

test/mocks/ContractOwner.sol Show resolved Hide resolved
src/plugins/owner/MultiOwnerPlugin.sol Outdated Show resolved Hide resolved
@fangting-alchemy fangting-alchemy merged commit 84f4b3d into audit-2023-11-20 Dec 12, 2023
3 checks passed
@fangting-alchemy fangting-alchemy deleted the ft_fix_mop branch December 12, 2023 21:33
jaypaik pushed a commit that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants