fix: [spearbit-97] Prevent createAccount() user error #16
+87
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-alchemy
suggested changes
Dec 12, 2023
adam-alchemy
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Looks good. I generally lean towards not copy/pasting code whenever possible, since it opens up the possibility of drift when one is changed but the other isn't. In this case it seems relatively small so I'm OK with going forward but we should revisit this in future versions.
howydev
added a commit
that referenced
this pull request
Dec 21, 2023
howydev
added a commit
that referenced
this pull request
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Factory's getAddress does not revert on invalid inputs to MultiOwnerPlugin which might potentially be a footgun for users/devs
Solution
Add these checks into getAddress in the 2 factories