Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [spearbit-15] IPlugin function prevention in installing execution functions #17

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

fangting-alchemy
Copy link
Collaborator

Copy link
Contributor

@adam-alchemy adam-alchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Flagging that this change does increase our codesize but we are still under the limit. Previous size was 24042, it is now 24362 (out of a max 24576).

src/account/PluginManagerInternals.sol Outdated Show resolved Hide resolved
@fangting-alchemy fangting-alchemy merged commit f70c9e5 into audit-2023-11-20 Dec 13, 2023
3 checks passed
@fangting-alchemy fangting-alchemy deleted the ft_fix_install branch December 13, 2023 19:43
jaypaik pushed a commit that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants