feat: use real entrypoint bytecode in tests #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contract sizes: | Contract | Size (B) | Margin (B) |
|------------------------------|----------|------------|
| AccountFactory | 4,763 | 19,813 |
| ERC1967Proxy | 104 | 24,472 |
| ModularAccount | 23,929 | 647 |
| SemiModularAccount | 25,019 | -443 |
| SingleSignerValidationModule | 3,444 | 21,132 |
| TokenReceiverModule | 2,189 | 22,387 |Code coverage:
|
adamegyed
force-pushed
the
adam/use-real-ep
branch
from
4591a56 to
19421eb
Compare
fangting-alchemy
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For accurate gas benchmarking, we shouldn't be deploying re-compiled EntryPoint code (via
new EntryPoint()), we should use the actual EntryPoint 0.7.0 code.Solution
Commit the binary + hex representations of EntryPoint 0.7.0 and its associated contract SenderCreator.
Add these to the setup step of OptimizedTest, and use this function in AccountTestBase.
Add a small verification test to ensure the codehash of these contracts is what we expect.
For future reference, the command used to generate the
.bytecodefiles isxxd -r -p name.hex > name.bytecode.Also renames the test file
ReferenceModularAccount.t.sol->ModularAccount.t.sol.