fix: [spearbit-99] Correctly set post-only hook flag #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-alchemy
changed the title
adam-alchemy
force-pushed
the
adam/fix-99
branch
from
be4903a to
bfb9b65
Compare
jaypaik
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
To go along with this change, I think we should update the following:
shouldClearHasPostHooks->shouldClearHasPostOnlyHooks
https://github.com/alchemyplatform/msca/blob/64cadc9f2766c7d036408f5d3d897edcd9b6aa4f/src/account/PluginManagerInternals.sol#L146-L147
https://github.com/alchemyplatform/msca/blob/64cadc9f2766c7d036408f5d3d897edcd9b6aa4f/src/account/PluginManagerInternals.sol#L195-L196shouldClearHasPostHooks->shouldClearHasPostOnlyHooks
https://github.com/alchemyplatform/msca/blob/64cadc9f2766c7d036408f5d3d897edcd9b6aa4f/src/account/PluginManagerInternals.sol#L238-L240
adam-alchemy
force-pushed
the
adam/fix-99
branch
from
64cadc9 to
ee5bed1
Compare
Makes sense, updated the variable naming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://github.com/spearbit-audits/alchemy-nov-review/issues/99
We set the
hasPostOnlyHooksflag incorrectly, enabling it when any post-exec hook is set.Solution
Only set this flag when it is specifically applying over a post-exec hook.