refactor: codesize reduction #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary by OctaneNew ContractsNo new contracts were added in this PR. Updated Contracts
🔗 Commit Hash: d7d699a |
Zer0dot
force-pushed
the
zer0dot/codesize-refactor
branch
from
69ff270 to
5340e72
Compare
|
Contract sizes: | Contract | Size (B) | Margin (B) |
|-------------------------------|----------|------------|
| AccountFactory | 4,814 | 19,762 |
| AllowlistModule | 9,903 | 14,673 |
| ExecutionInstallDelegate | 5,694 | 18,882 |
| ModularAccount | 21,971 | 2,605 |
| NativeFunctionDelegate | 434 | 24,142 |
| NativeTokenLimitModule | 4,258 | 20,318 |
| PaymasterGuardModule | 1,797 | 22,779 |
| SemiModularAccountBytecode | 24,045 | 531 |
| SemiModularAccountStorageOnly | 24,539 | 37 |
| SingleSignerValidationModule | 4,300 | 20,276 |
| TimeRangeModule | 2,000 | 22,576 |
| WebAuthnValidationModule | 7,854 | 16,722 |Code coverage:
|
Overview
Detailed findings
|
Zer0dot
force-pushed
the
zer0dot/codesize-refactor
branch
2 times, most recently
from
c8f1ff5 to
dea2d9c
Compare
Zer0dot
force-pushed
the
zer0dot/codesize-refactor
branch
from
6a8cfa7 to
250cd57
Compare
Zer0dot
force-pushed
the
zer0dot/codesize-refactor
branch
from
78467a7 to
35e0d20
Compare
adamegyed
reviewed
Oct 16, 2024
Zer0dot
force-pushed
the
zer0dot/codesize-refactor
branch
4 times, most recently
from
6106d8d to
631f31f
Compare
Zer0dot
force-pushed
the
zer0dot/codesize-refactor
branch
from
af54caf to
8b3da4f
Compare
adamegyed
reviewed
Oct 16, 2024
jaypaik
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to reduce code size to fit under the Spurious Dragon limit of 24576 bytes.
Solution
Various refactors, including:
domainSeparator()and potentially other offchain-computable functions.