Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump ref-impl and update imports #245

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

jaypaik
Copy link
Collaborator

@jaypaik jaypaik commented Oct 15, 2024

  • Bumped reference-implementation to v0.8.0-rc.5.
  • Deleted src/helpers/EmptyCalldataSlice.sol and src/libraries/SparseCalldataSegmentLib.sol in favor of identical imports from reference-implementation.
  • Removed duplicate constants from Constants.sol in favor of identical imports from reference-implementation.

@jaypaik jaypaik requested a review from a team October 15, 2024 18:59
Copy link

octane-security-app bot commented Oct 15, 2024

Summary by Octane

New Contracts

No new contracts were added in this PR.

Updated Contracts

  • ModularAccountBase.sol: Added validation, calldata slicing, and sparse calldata functionality; reorganized imports for ERC6900 compliance.
  • ModuleManagerInternals.sol: The smart contract update relocates a constant import, optimizing code organization without altering primary functionality.
  • SemiModularAccountBase.sol: Added an import for DIRECT_CALL_VALIDATION_ENTITYID and refined constant imports for modular account functionalities.
  • Constants.sol: Removed validation data indices, validation hooks, and direct call validation entity ID, retaining only fallback validation.
  • ReturnDataModuleMocks.sol: Imported the DIRECT_CALL_VALIDATION_ENTITYID from a different source.
  • AccountTestBase.sol: Updated import sources for the DIRECT_CALL_VALIDATION_ENTITYID to a different location for code organization improvements.
  • ModuleSignatureUtils.sol: Enhanced modular account functionality by updating import sources and reordering constants for improved clarity and validation.

🔗 Commit Hash: 8842cea

@jaypaik jaypaik marked this pull request as draft October 15, 2024 19:00
@jaypaik jaypaik force-pushed the 10-15-feat_bump_ref-impl_and_update_imports branch from 1b77248 to 8842cea Compare October 15, 2024 20:07
@jaypaik jaypaik marked this pull request as ready for review October 15, 2024 20:08
@jaypaik jaypaik requested review from a team and removed request for a team October 15, 2024 20:08
Copy link

Contract sizes:

| Contract                      | Size (B) | Margin (B) |
|-------------------------------|----------|------------|
| AccountFactory                |    4,814 |     19,762 |
| AllowlistModule               |    9,230 |     15,346 |
| ECDSAValidationModule         |    3,646 |     20,930 |
| ModularAccount                |   25,655 |     -1,079 |
| NativeTokenLimitModule        |    4,714 |     19,862 |
| PaymasterGuardModule          |    1,797 |     22,779 |
| SemiModularAccountBytecode    |   27,553 |     -2,977 |
| SemiModularAccountStorageOnly |   28,071 |     -3,495 |
| TimeRangeModule               |    2,000 |     22,576 |
| WebauthnValidationModule      |    7,854 |     16,722 |

Code coverage:

File % Lines % Statements % Branches % Funcs
src/account/AccountStorageInitializable.sol 89.47% (17/19) 96.15% (25/26) 80.00% (4/5) 100.00% (2/2)
src/account/BaseAccount.sol 87.50% (7/8) 85.71% (6/7) 50.00% (1/2) 100.00% (4/4)
src/account/ModularAccount.sol 100.00% (1/1) 100.00% (1/1) 100.00% (0/0) 100.00% (2/2)
src/account/ModularAccountBase.sol 95.39% (290/304) 93.51% (360/385) 67.80% (40/59) 100.00% (38/38)
src/account/ModularAccountView.sol 100.00% (26/26) 100.00% (33/33) 100.00% (2/2) 100.00% (2/2)
src/account/ModuleManagerInternals.sol 88.10% (111/126) 86.83% (145/167) 50.00% (8/16) 100.00% (12/12)
src/account/SemiModularAccountBase.sol 87.69% (57/65) 91.21% (83/91) 66.67% (10/15) 94.74% (18/19)
src/account/SemiModularAccountBytecode.sol 100.00% (5/5) 100.00% (6/6) 100.00% (1/1) 50.00% (1/2)
src/account/SemiModularAccountStorageOnly.sol 100.00% (4/4) 100.00% (5/5) 100.00% (0/0) 100.00% (2/2)
src/account/TokenReceiver.sol 33.33% (1/3) 33.33% (1/3) 100.00% (0/0) 33.33% (1/3)
src/factory/AccountFactory.sol 70.59% (24/34) 76.09% (35/46) 40.00% (2/5) 58.33% (7/12)
src/libraries/ExecutionLib.sol 98.39% (244/248) 97.18% (241/248) 88.00% (22/25) 100.00% (22/22)
src/libraries/KnownSelectorsLib.sol 100.00% (29/29) 100.00% (64/64) 100.00% (0/0) 100.00% (3/3)
src/libraries/LinkedListSetLib.sol 94.00% (47/50) 96.25% (77/80) 66.67% (4/6) 100.00% (8/8)
src/libraries/MemManagementLib.sol 100.00% (54/54) 100.00% (70/70) 100.00% (0/0) 100.00% (12/12)
src/libraries/SemiModularKnownSelectorsLib.sol 100.00% (6/6) 100.00% (12/12) 100.00% (0/0) 100.00% (1/1)
src/modules/BaseModule.sol 100.00% (13/13) 94.12% (16/17) 100.00% (2/2) 100.00% (3/3)
src/modules/permissions/AllowlistModule.sol 86.05% (74/86) 85.71% (96/112) 78.26% (18/23) 50.00% (9/18)
src/modules/permissions/NativeTokenLimitModule.sol 87.80% (36/41) 89.66% (52/58) 88.89% (8/9) 54.55% (6/11)
src/modules/permissions/PaymasterGuardModule.sol 80.00% (8/10) 66.67% (10/15) 100.00% (2/2) 57.14% (4/7)
src/modules/permissions/TimeRangeModule.sol 83.33% (10/12) 80.00% (16/20) 100.00% (1/1) 75.00% (6/8)
src/modules/validation/ECDSAValidationModule.sol 92.00% (23/25) 81.58% (31/38) 62.50% (5/8) 90.00% (9/10)
src/modules/validation/WebauthnValidationModule.sol 61.11% (11/18) 66.67% (18/27) 100.00% (3/3) 60.00% (6/10)
Total 92.50% (1098/1187) 91.64% (1403/1531) 72.28% (133/184) 84.36% (178/211)

Copy link

Overview

Octane AI analysis has finished. No vulnerabilities were found. Cheers! 🎉🎉🎉


🔗 Commit Hash: 8842cea

@jaypaik jaypaik merged commit 0848a8c into develop Oct 15, 2024
6 checks passed
@jaypaik jaypaik deleted the 10-15-feat_bump_ref-impl_and_update_imports branch October 15, 2024 20:23
howydev pushed a commit that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants