fix: rename ValidationData and ExecutionData

[jaypaik]

To reduce confusion with ERC-4337's validationData.

[octane-security-app]

Summary by Octane

New Contracts

No new contracts were added in this PR.

Updated Contracts

• AccountStorage.sol: The smart contract renamed "ExecutionData" to "ExecutionStorage" and "ValidationData" to "ValidationStorage."
• ModularAccountBase.sol: The smart contract changed its storage access from validationData and executionData to validationStorage and executionStorage.
• ModularAccountView.sol: The smart contract update involves renaming data storage structures and ensuring consistent operations on ExecutionStorage and ValidationStorage.
• ModuleManagerInternals.sol: The code refactor modifies ExecutionData and ValidationData to ExecutionStorage and ValidationStorage, enhancing the structure and functionality.
• MemManagementLib.sol: The smart contract now uses ExecutionStorage and ValidationStorage in place of ExecutionData and ValidationData.
• StorageAccesses.sol: Modified naming conventions for slots related to validation and execution data, emphasizing "storage" terminology.

---

🔗 Commit Hash: e4ca42c

[github-actions]

Contract sizes:

| Contract                      | Size (B) | Margin (B) |
|-------------------------------|----------|------------|
| AccountFactory                |    4,814 |     19,762 |
| AllowlistModule               |    9,230 |     15,346 |
| ECDSAValidationModule         |    3,646 |     20,930 |
| ModularAccount                |   25,655 |     -1,079 |
| NativeTokenLimitModule        |    4,714 |     19,862 |
| PaymasterGuardModule          |    1,797 |     22,779 |
| SemiModularAccountBytecode    |   27,553 |     -2,977 |
| SemiModularAccountStorageOnly |   28,071 |     -3,495 |
| TimeRangeModule               |    2,000 |     22,576 |
| WebauthnValidationModule      |    7,854 |     16,722 |

Code coverage:

File	% Lines	% Statements	% Branches	% Funcs
src/account/AccountStorageInitializable.sol	100.00% (19/19)	100.00% (26/26)	100.00% (5/5)	100.00% (2/2)
src/account/BaseAccount.sol	87.50% (7/8)	85.71% (6/7)	50.00% (1/2)	100.00% (4/4)
src/account/ModularAccount.sol	100.00% (1/1)	100.00% (1/1)	100.00% (0/0)	100.00% (2/2)
src/account/ModularAccountBase.sol	95.39% (290/304)	93.51% (360/385)	67.80% (40/59)	100.00% (38/38)
src/account/ModularAccountView.sol	100.00% (26/26)	100.00% (33/33)	100.00% (2/2)	100.00% (2/2)
src/account/ModuleManagerInternals.sol	88.10% (111/126)	86.83% (145/167)	50.00% (8/16)	100.00% (12/12)
src/account/SemiModularAccountBase.sol	87.69% (57/65)	91.21% (83/91)	66.67% (10/15)	94.74% (18/19)
src/account/SemiModularAccountBytecode.sol	100.00% (5/5)	100.00% (6/6)	100.00% (1/1)	50.00% (1/2)
src/account/SemiModularAccountStorageOnly.sol	100.00% (4/4)	100.00% (5/5)	100.00% (0/0)	100.00% (2/2)
src/account/TokenReceiver.sol	33.33% (1/3)	33.33% (1/3)	100.00% (0/0)	33.33% (1/3)
src/factory/AccountFactory.sol	70.59% (24/34)	76.09% (35/46)	40.00% (2/5)	58.33% (7/12)
src/libraries/ExecutionLib.sol	98.39% (244/248)	97.18% (241/248)	88.00% (22/25)	100.00% (22/22)
src/libraries/KnownSelectorsLib.sol	100.00% (29/29)	100.00% (64/64)	100.00% (0/0)	100.00% (3/3)
src/libraries/LinkedListSetLib.sol	94.00% (47/50)	96.25% (77/80)	66.67% (4/6)	100.00% (8/8)
src/libraries/MemManagementLib.sol	100.00% (54/54)	100.00% (70/70)	100.00% (0/0)	100.00% (12/12)
src/libraries/SemiModularKnownSelectorsLib.sol	100.00% (6/6)	100.00% (12/12)	100.00% (0/0)	100.00% (1/1)
src/modules/BaseModule.sol	100.00% (13/13)	94.12% (16/17)	100.00% (2/2)	100.00% (3/3)
src/modules/permissions/AllowlistModule.sol	86.05% (74/86)	85.71% (96/112)	78.26% (18/23)	50.00% (9/18)
src/modules/permissions/NativeTokenLimitModule.sol	87.80% (36/41)	89.66% (52/58)	88.89% (8/9)	54.55% (6/11)
src/modules/permissions/PaymasterGuardModule.sol	80.00% (8/10)	66.67% (10/15)	100.00% (2/2)	57.14% (4/7)
src/modules/permissions/TimeRangeModule.sol	83.33% (10/12)	80.00% (16/20)	100.00% (1/1)	75.00% (6/8)
src/modules/validation/ECDSAValidationModule.sol	92.00% (23/25)	81.58% (31/38)	62.50% (5/8)	90.00% (9/10)
src/modules/validation/WebauthnValidationModule.sol	61.11% (11/18)	66.67% (18/27)	100.00% (3/3)	60.00% (6/10)
Total	92.67% (1100/1187)	91.70% (1404/1531)	72.83% (134/184)	84.36% (178/211)

[octane-security-app]

Overview

Vulnerabilities found:	10
Severity breakdown:	3 Critical, 2 High, 5 Medium

Detailed findings

src/account/ModularAccountBase.sol

• Review potential Denial of Service issue that is exposed in the isValidSignature function
• Review potential Denial of Service issue that is exposed in the uninstallExecution function
• Review potential Denial of Service issue that is exposed in the uninstallValidation function
• Review potential Denial of Service issue that is exposed in the __fallback__ function
• Review potential Incorrect Nonce Update (Signature Replay Attack) issue that is exposed in the executeUserOp function
• Review potential Reentrancy issue that is exposed in the executeUserOp function
• Review potential Validation Check Does Not Fall Through issue that is exposed in the uninstallValidation function
• Review potential Validation Check Does Not Fall Through issue that is exposed in the uninstallExecution function

src/factory/AccountFactory.sol

• Review potential Incorrect Nonce Update (Signature Replay Attack) issue that is exposed in the createAccount function
• Review potential Reentrancy issue that is exposed in the createAccount function

---

🔗 Commit Hash: fe2db80
🛡️ Octane Dashboard: All vulnerabilities