Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix casing for WebAuthnValidationModule #250

Merged
merged 1 commit into from
Oct 15, 2024
Merged

refactor: fix casing for WebAuthnValidationModule #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...s/validation/WebauthnValidationModule.sol → ...s/validation/WebAuthnValidationModule.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ import {IModule} from "@erc6900/reference-implementation/interfaces/IModule.sol"
import {IValidationModule} from "@erc6900/reference-implementation/interfaces/IValidationModule.sol";
import {BaseModule} from "@erc6900/reference-implementation/modules/BaseModule.sol";

/// @title Webauthn Validation
/// @title WebAuthn Validation
/// @author Alchemy
/// @dev Implementation referenced from Webauthn + Coinbase Smart Wallet developed by Base.
/// @notice This validation module enables Webauthn (secp256r1 curve) signature validation.
/// @dev Implementation referenced from WebAuthn + Coinbase Smart Wallet developed by Base.
/// @notice This validation module enables WebAuthn (secp256r1 curve) signature validation.
/// Note:
/// - Uninstallation will NOT disable all installed entity IDs of an account. It only uninstalls the
/// entity ID that is passed in. Account must remove access for each entity ID if want to disable all.
Expand All @@ -39,7 +39,7 @@ import {BaseModule} from "@erc6900/reference-implementation/modules/BaseModule.s
/// - This validation supports ERC-1271. The signature is valid if it is signed by the owner's private key.
/// - This validation supports composition that other validation can relay on entities in this validation
/// to validate partially or fully.
contract WebauthnValidationModule is IValidationModule, ReplaySafeWrapper, BaseModule {
contract WebAuthnValidationModule is IValidationModule, ReplaySafeWrapper, BaseModule {
using MessageHashUtils for bytes32;
using WebAuthn for WebAuthn.WebAuthnAuth;

Expand Down
8 changes: 4 additions & 4 deletions test/modules/WebauthnValidationModule.t.sol → test/modules/WebAuthnValidationModule.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ import {Utils, WebAuthnInfo} from "webauthn-sol/test/Utils.sol";

import {ModularAccount} from "../../src/account/ModularAccount.sol";
import {ModularAccountBase} from "../../src/account/ModularAccountBase.sol";
import {WebauthnValidationModule} from "../../src/modules/validation/WebauthnValidationModule.sol";
import {WebAuthnValidationModule} from "../../src/modules/validation/WebAuthnValidationModule.sol";
import {AccountTestBase} from "../utils/AccountTestBase.sol";
import {CODELESS_ADDRESS} from "../utils/TestConstants.sol";

contract WebauthnValidationModuleTest is AccountTestBase {
contract WebAuthnValidationModuleTest is AccountTestBase {
using MessageHashUtils for bytes32;

WebauthnValidationModule public module;
WebAuthnValidationModule public module;
address payable public account;
uint32 public entityId = 1;
// Example key from Coinbase Smart Wallet
Expand All @@ -32,7 +32,7 @@ contract WebauthnValidationModuleTest is AccountTestBase {
uint256 internal constant _SIG_VALIDATION_FAILED = 1;

function setUp() public override {
module = new WebauthnValidationModule();
module = new WebAuthnValidationModule();
account = payable(account1);
vm.prank(address(entryPoint));
ModularAccount(account).installValidation(
Expand Down
Loading