refactor: add docs + cleanup MA and MABase with small opt #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fangting-alchemy
commented
Oct 16, 2024
fangting-alchemy
commented
- Add NatSpecs
- Small refactor on comments and code
- tiny opt by rid of one error
Summary by OctaneNew ContractsNo new contracts were added in this PR. Updated Contracts
🔗 Commit Hash: 490845c |
fangting-alchemy
changed the title
|
Contract sizes: | Contract | Size (B) | Margin (B) |
|-------------------------------|----------|------------|
| AccountFactory | 4,814 | 19,762 |
| AllowlistModule | 9,230 | 15,346 |
| ModularAccount | 25,167 | -591 |
| NativeTokenLimitModule | 4,714 | 19,862 |
| PaymasterGuardModule | 1,797 | 22,779 |
| SemiModularAccountBytecode | 27,775 | -3,199 |
| SemiModularAccountStorageOnly | 28,293 | -3,717 |
| SingleSignerValidationModule | 4,300 | 20,276 |
| TimeRangeModule | 2,000 | 22,576 |
| WebAuthnValidationModule | 7,854 | 16,722 |Code coverage:
|
adamegyed
reviewed
Oct 16, 2024
Overview
Detailed findings
|
Zer0dot
reviewed
Oct 16, 2024
src/account/ModularAccount.sol
Outdated
| @@ -6,6 +6,10 @@ import {IEntryPoint} from "@eth-infinitism/account-abstraction/interfaces/IEntry | |||
|
|
|||
| import {ModularAccountBase} from "./ModularAccountBase.sol"; | |||
|
|
|||
| /// @title Modular Account | |||
| /// @author Alchemy | |||
| /// @notice This contract allow initionalizing with a validation config (of a validation module) to be installed on | |||
There was a problem hiding this comment.
Suggested change
| /// @notice This contract allow initionalizing with a validation config (of a validation module) to be installed on | |
| /// @notice This contract allow initializing with a validation config (of a validation module) to be installed on |
Zer0dot
reviewed
Oct 16, 2024
src/account/ModularAccountBase.sol
Outdated
| @@ -43,6 +43,10 @@ import {ModularAccountView} from "./ModularAccountView.sol"; | |||
| import {ModuleManagerInternals} from "./ModuleManagerInternals.sol"; | |||
| import {TokenReceiver} from "./TokenReceiver.sol"; | |||
|
|
|||
| /// @title Modular Account Base | |||
| /// @author Alchemy | |||
| /// @notice This abstract account is a modular account that is compliant with ERC-6900 standard. It supports | |||
There was a problem hiding this comment.
Suggested change
| /// @notice This abstract account is a modular account that is compliant with ERC-6900 standard. It supports | |
| /// @notice This abstract contract is a modular account that is compliant with ERC-6900 standard. It supports |
adamegyed
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.