chore: optimize Base module a bit #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary by OctaneNew ContractsNo new contracts were added in this PR. Updated Contracts
🔗 Commit Hash: 09048d0 |
|
Contract sizes: | Contract | Size (B) | Margin (B) |
|-------------------------------|----------|------------|
| AccountFactory | 4,814 | 19,762 |
-| AllowlistModule | 9,230 | 15,346 |
+| AllowlistModule | 8,889 | 15,687 |
| ModularAccount | 25,284 | -708 |
-| NativeTokenLimitModule | 4,714 | 19,862 |
+| NativeTokenLimitModule | 4,310 | 20,266 |
| PaymasterGuardModule | 1,797 | 22,779 |
| SemiModularAccountBytecode | 27,903 | -3,327 |
| SemiModularAccountStorageOnly | 28,421 | -3,845 |
| SingleSignerValidationModule | 4,300 | 20,276 |
| TimeRangeModule | 2,000 | 22,576 |
| WebAuthnValidationModule | 7,854 | 16,722 |Code coverage:
|
fangting-alchemy
force-pushed
the
base
branch
from
6dd1e06 to
5de5546
Compare
howydev
approved these changes
Oct 16, 2024
adamegyed
reviewed
Oct 16, 2024
src/modules/BaseModule.sol
Outdated
| assembly { | ||
| selector := mload(add(callData, 36)) | ||
| // Copy actualSelector into a new var | ||
| selector := mload(add(finalCalldata, 36)) |
There was a problem hiding this comment.
We should clean the lower 28 bytes
Suggested change
| selector := mload(add(finalCalldata, 36)) | |
| selector := shl(224, mload(add(finalCalldata, 8))) |
adamegyed
reviewed
Oct 16, 2024
src/modules/BaseModule.sol
Outdated
| // Bytes arr representation: [bytes32(len), bytes4(executeUserOp.selector), bytes4(actualSelector), | ||
| // bytes(actualCallData)] | ||
| // 1. Copy actualSelector into a new var | ||
| // 2. Shorten bytes arry by 8 by: store length - 8 into the new pointer location | ||
| // 3. Move the callData pointer by 8 | ||
| assembly { |
There was a problem hiding this comment.
Suggested change
| assembly { | |
| assembly ("memory-safe") { |
This comment was marked as off-topic.
This comment was marked as off-topic.
fangting-alchemy
force-pushed
the
base
branch
from
5de5546 to
5f0dc50
Compare
fangting-alchemy
force-pushed
the
base
branch
from
5f0dc50 to
09048d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimization